getBreadcrumbsArray is broken if a label is used twice in a path #47

Closed
stof opened this Issue Apr 19, 2012 · 0 comments

Projects

None yet

1 participant

@stof

There is absolutely no constraint about labels in KnpMenu. But while working on #45, I figured that the label is used as key in the return value of getBreadcrumbsArray, meaning the method is totally broken when a label is used twice in a path in the tree.

Fixing it would require a BC break as the bug comes from the design chosen for the method (which still comes from ioMenuPlugin)

@stof stof added a commit that closed this issue May 4, 2012
@stof stof Refactored the format of the breadcrumb array
Fixes #47
ce6bbaa
@stof stof closed this in ce6bbaa May 4, 2012
@stof stof reopened this May 4, 2012
@stof stof closed this in 30346c5 May 17, 2012
@bamarni bamarni pushed a commit to bamarni/KnpMenu that referenced this issue Aug 8, 2012
@GromNaN GromNaN Missing namespace in MenuFactory default item class fix #47 364c933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment