Since CoreExtension is loaded with a low priority in MenuFactory, prior extensions setting extras at item building time currently get their values overriden.
NB : Sorry about the messed up PRs. This is the one.
Don't override existing extras when building item
you don't need to create a new PR each time. You can simply force the push to the branch
I thought that was what I did yesterday and got puzzled, sorry again.
Not even a review ?
@stof anything against this PR ?
coding standard https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md
I fixed code style according to PSR-2
Weird, why you PR can't pass tests ? o_o
Well it does : https://travis-ci.org/KnpLabs/KnpMenu/builds/17988387
First commit did not but i fixed it
I had something weird frome here, now it's ok :)
Thank you very much.