Skip to content

Dont override extras #118

merged 3 commits into from Feb 3, 2014

4 participants


Since CoreExtension is loaded with a low priority in MenuFactory, prior extensions setting extras at item building time currently get their values overriden.

NB : Sorry about the messed up PRs. This is the one.

stof commented Jan 8, 2014

you don't need to create a new PR each time. You can simply force the push to the branch


I thought that was what I did yesterday and got puzzled, sorry again.


Not even a review ?

Nek- commented Jan 31, 2014

@stof anything against this PR ?


I fixed code style according to PSR-2

Nek- commented Jan 31, 2014

Weird, why you PR can't pass tests ? o_o


Well it does :
First commit did not but i fixed it

Nek- commented Feb 3, 2014

I had something weird frome here, now it's ok :)

Thank you very much.

@Nek- Nek- merged commit 835ee51 into KnpLabs:master Feb 3, 2014

1 check passed

Details default The Travis CI build passed


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.