Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align method signature with interface #313

Merged
merged 3 commits into from Oct 9, 2019

Conversation

@u01jmg3
Copy link
Contributor

commented Oct 9, 2019

  • MenuItem::getLinkAttribute(string $name, $default = null)
  • ItemInterface::setChildrenAttribute(string $name, $value)
src/Knp/Menu/MenuItem.php Outdated Show resolved Hide resolved
u01jmg3 added 2 commits Oct 9, 2019
@garak
garak approved these changes Oct 9, 2019
@garak garak merged commit 0ba4eb7 into KnpLabs:master Oct 9, 2019
2 checks passed
2 checks passed
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@garak

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2019

Thanks @u01jmg3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.