Skip to content

Add option currentScanDepth to renderers #98

Merged
merged 8 commits into from Jan 31, 2014

4 participants

@sebastianljunggren

As suggested in #96. I've not managed to come up with a better name for the option.

This is my first pull request so please tell me if I've missed something.

@stof
KNP Labs member
stof commented Mar 19, 2013

Please add a test in the abstract renderer test for this option (and you will see that the TwigRenderer is broken as you never decrement the depth)

For the naming, I would suggest matchingDepth

@sebastianljunggren

I changed the name and added some very basic tests of the option.

@apfelbox

Is there something missing? Can this be merged? It seems that this is one of the very big missing features.

@stof @sebastianljunggren

@Nek- Nek- merged commit 9f4235f into KnpLabs:master Jan 31, 2014

1 check passed

Details default The Travis build passed
@Nek-
Nek- commented Jan 31, 2014

Thanks :-) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.