Add option currentScanDepth to renderers #98

Merged
merged 8 commits into from Jan 31, 2014

Conversation

Projects
None yet
4 participants
@sebastianljunggren
Contributor

sebastianljunggren commented Mar 17, 2013

As suggested in #96. I've not managed to come up with a better name for the option.

This is my first pull request so please tell me if I've missed something.

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Mar 19, 2013

Collaborator

Please add a test in the abstract renderer test for this option (and you will see that the TwigRenderer is broken as you never decrement the depth)

For the naming, I would suggest matchingDepth

Collaborator

stof commented Mar 19, 2013

Please add a test in the abstract renderer test for this option (and you will see that the TwigRenderer is broken as you never decrement the depth)

For the naming, I would suggest matchingDepth

@sebastianljunggren

This comment has been minimized.

Show comment
Hide comment
@sebastianljunggren

sebastianljunggren Mar 20, 2013

Contributor

I changed the name and added some very basic tests of the option.

Contributor

sebastianljunggren commented Mar 20, 2013

I changed the name and added some very basic tests of the option.

@apfelbox

This comment has been minimized.

Show comment
Hide comment
@apfelbox

apfelbox Nov 27, 2013

Is there something missing? Can this be merged? It seems that this is one of the very big missing features.

@stof @sebastianljunggren

Is there something missing? Can this be merged? It seems that this is one of the very big missing features.

@stof @sebastianljunggren

Nek- added a commit that referenced this pull request Jan 31, 2014

Merge pull request #98 from sebastianljunggren/master
Add option currentScanDepth to renderers

@Nek- Nek- merged commit 9f4235f into KnpLabs:master Jan 31, 2014

1 check passed

default The Travis build passed
Details
@Nek-

This comment has been minimized.

Show comment
Hide comment
@Nek-

Nek- Jan 31, 2014

Collaborator

Thanks :-) .

Collaborator

Nek- commented Jan 31, 2014

Thanks :-) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment