New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering submenus code example fixed for coherence #211

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@rodrigodiez

rodrigodiez commented Jan 19, 2014

No description provided.

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Jan 19, 2014

Collaborator

The example showing how to render a submenu directly in knp_menu_render should be kept IMO, otherwise it becomes undocumented

Collaborator

stof commented Jan 19, 2014

The example showing how to render a submenu directly in knp_menu_render should be kept IMO, otherwise it becomes undocumented

@rodrigodiez

This comment has been minimized.

Show comment
Hide comment
@rodrigodiez

rodrigodiez Jan 19, 2014

Then I would write a full doc example for both render ways (passing a menuItem instance or a path array). It's not clear enough, I had to dive in code to fully understand the current behaviour

rodrigodiez commented Jan 19, 2014

Then I would write a full doc example for both render ways (passing a menuItem instance or a path array). It's not clear enough, I had to dive in code to fully understand the current behaviour

@wysow

This comment has been minimized.

Show comment
Hide comment
@wysow

wysow Mar 6, 2015

@rodrigodiez Thanks for your contribution, can you rebase this PR and add the missing doc example?

wysow commented Mar 6, 2015

@rodrigodiez Thanks for your contribution, can you rebase this PR and add the missing doc example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment