New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Builder Alias symfony3.3 support #362

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Kronhyx

Kronhyx commented Nov 16, 2017

No description provided.

kronhyx
@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Nov 20, 2017

Collaborator

What was the issue with Symfony 3.3 ?

Collaborator

stof commented Nov 20, 2017

What was the issue with Symfony 3.3 ?

@Kronhyx

This comment has been minimized.

Show comment
Hide comment
@Kronhyx

Kronhyx Nov 20, 2017

when I call knp_menu_get ('App:CustomMenu:Locale') he does not recognize that App because it is not a bundle and an exception is generated

Kronhyx commented Nov 20, 2017

when I call knp_menu_get ('App:CustomMenu:Locale') he does not recognize that App because it is not a bundle and an exception is generated

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Nov 21, 2017

Collaborator

Well, what you are asking for is not Symfony 3.3+ support. It is support for bundle-less apps. This is indeed not supported yet. But I'm not sure I want to support this either. Registering menu builders as services is much better IMO (and for Symfony 4, I will soon provide a way to have them taking profit of autoconfiguration on Symfony 3.3+)

Collaborator

stof commented Nov 21, 2017

Well, what you are asking for is not Symfony 3.3+ support. It is support for bundle-less apps. This is indeed not supported yet. But I'm not sure I want to support this either. Registering menu builders as services is much better IMO (and for Symfony 4, I will soon provide a way to have them taking profit of autoconfiguration on Symfony 3.3+)

@Kronhyx

This comment has been minimized.

Show comment
Hide comment
@Kronhyx

Kronhyx Nov 21, 2017

Well, what am I supposed to do? Many developers use applications without packages and probably present this problem in the future

Kronhyx commented Nov 21, 2017

Well, what am I supposed to do? Many developers use applications without packages and probably present this problem in the future

@lsv lsv referenced this pull request Jan 2, 2018

Closed

Symfony 4 - Menu as event #380

@Kronhyx Kronhyx closed this Sep 11, 2018

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Sep 12, 2018

Collaborator

The better solution is to define menu builders as services (which also allows using DI in them)

Collaborator

stof commented Sep 12, 2018

The better solution is to define menu builders as services (which also allows using DI in them)

@Kronhyx

This comment has been minimized.

Show comment
Hide comment
@Kronhyx

Kronhyx Sep 12, 2018

ok @stof , thx for all

Kronhyx commented Sep 12, 2018

ok @stof , thx for all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment