Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a MenuBuilderProviderInterface to support autoconfiguration #392

Open
wants to merge 1 commit into
base: master
from

Conversation

@stof
Copy link
Collaborator

commented Sep 16, 2018

This interface allows defining the menu names from the class itself instead of having to define them in the service definition. This is similar to the event subscriber vs event listener system in Symfony.
The benefit of this interface is that the service definition can rely on autoconfiguration to register everything, which fits very well with the Flex way.

TODOs:

  • write tests
Implement a MenuBuilderProviderInterface to support autoconfiguration
This interface allows defining the menu names from the class itself instead
of having to define them in the service definition. This is similar to the
event subscriber vs event listener system in Symfony.
The benefit of this interface is that the service definition can rely on
autoconfiguration to register everything, which fits very well with the Flex
way.
@dbu
Copy link
Collaborator

left a comment

i like this a lot!

@dbu

dbu approved these changes Sep 17, 2018

Copy link
Collaborator

left a comment

both the idea and the implementation make sense to me, thanks stof!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.