Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a priority to allow controlling the order of providers #404

Open

Conversation

@emulienfou
Copy link

commented Apr 16, 2019

This Pull Request introduce a new feature to allow specifying the priority of providers during the registration of a new provider when this one has been tagged. (Similar has voters)

So, a developer will now be able to write something like:

services:
  app.menu_provider:
        class: AppBundle\Provider\CustomMenuProvider
        arguments:
          - @knp_menu.factory
        tags:
          - { name: knp_menu.provider, priority: 20 }
@dbu

dbu approved these changes Apr 30, 2019

Copy link
Collaborator

left a comment

looks good to me, and you are even adding a test.

some nitpicks on the test, otherwise seems ready to me.

emulienfou and others added some commits Apr 30, 2019

David Sanchez
@dbu

dbu approved these changes May 2, 2019

Copy link
Collaborator

left a comment

only some cosmetics left.

@stof wdyt? (or is somebody else maintaining this bundle?)

@garak

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

I think this PR should include an update to documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.