Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate "container_aware" option #414

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@garak
Copy link
Collaborator

commented Sep 6, 2019

No description provided.

@garak garak requested a review from stof Sep 6, 2019

src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@garak

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 6, 2019

Requested changes should be implemented. Failure on dev in travis should be unrelated.
Can we merge?

@garak garak force-pushed the garak:deprecate-option branch from 5d7b8d5 to 2e40685 Sep 11, 2019

@garak garak force-pushed the garak:deprecate-option branch from 4cd3d2e to 66d54e1 Sep 11, 2019

@garak garak requested a review from stof Sep 12, 2019

@garak garak merged commit cd22849 into KnpLabs:master Sep 19, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details

@garak garak deleted the garak:deprecate-option branch Sep 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.