Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add php 7.2 #470

Merged
merged 3 commits into from Mar 20, 2018

Conversation

Projects
None yet
2 participants
@andreybolonin
Copy link
Contributor

andreybolonin commented Jan 22, 2018

No description provided.

andreybolonin added some commits Jan 22, 2018

.travis.yml Outdated
fast_finish: true

before_script:
- if [ "$SYMFONY_VERSION" != "" ]; then composer require --no-update "symfony/framework-bundle:${SYMFONY_VERSION}"; fi;

This comment has been minimized.

@nicolasmure

nicolasmure Jan 23, 2018

Member

This line should be kept as there're different SF versions to test in the matrix.

@andreybolonin

This comment has been minimized.

Copy link
Contributor Author

andreybolonin commented Mar 19, 2018

@nicolasmure
Copy link
Member

nicolasmure left a comment

Thank you @andreybolonin !

@nicolasmure nicolasmure merged commit b2b5e53 into KnpLabs:master Mar 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.