From bc1de6ab9c31ab6ab4648830a58de927f0590c3c Mon Sep 17 00:00:00 2001
From: Klein Florian <florian.klein@free.fr>
Date: Fri, 12 Apr 2013 10:54:25 +0200
Subject: [PATCH] do not add form children dynamically; only on default form
 creator; refs #45

---
 Form/DefaultFormCreator.php       |  1 +
 Form/FormTypeExtension.php        | 29 -----------------------------
 Resources/config/form_manager.xml |  6 ------
 3 files changed, 1 insertion(+), 35 deletions(-)
 delete mode 100644 Form/FormTypeExtension.php

diff --git a/Form/DefaultFormCreator.php b/Form/DefaultFormCreator.php
index 09c8a60..b0c25a6 100644
--- a/Form/DefaultFormCreator.php
+++ b/Form/DefaultFormCreator.php
@@ -33,6 +33,7 @@ public static function getSubscribedEvents()
     public function create($object, $purpose = null, array $options = array())
     {
         $builder = $this->factory->createBuilder('form', $object, $options);
+        $builder->addEventSubscriber($this);
 
         return $builder->getForm();
     }
diff --git a/Form/FormTypeExtension.php b/Form/FormTypeExtension.php
deleted file mode 100644
index 7df86a6..0000000
--- a/Form/FormTypeExtension.php
+++ /dev/null
@@ -1,29 +0,0 @@
-<?php
-
-namespace Knp\RadBundle\Form;
-
-use Symfony\Component\Form\AbstractTypeExtension;
-use Symfony\Component\Form\FormBuilderInterface;
-
-use Knp\RadBundle\Form\DefaultFormCreator;
-
-class FormTypeExtension extends AbstractTypeExtension
-{
-    private $formCreator;
-
-    public function __construct(DefaultFormCreator $formCreator)
-    {
-        $this->formCreator = $formCreator;
-    }
-
-    public function getExtendedType()
-    {
-        return 'form';
-    }
-
-    public function buildForm(FormBuilderInterface $builder, array $options)
-    {
-        $builder->addEventSubscriber($this->formCreator);
-    }
-}
-
diff --git a/Resources/config/form_manager.xml b/Resources/config/form_manager.xml
index 941d5ee..b053c80 100644
--- a/Resources/config/form_manager.xml
+++ b/Resources/config/form_manager.xml
@@ -9,7 +9,6 @@
         <parameter key="knp_rad.form.type_creator.class">Knp\RadBundle\Form\FormTypeCreator</parameter>
         <parameter key="knp_rad.form.default_creator.class">Knp\RadBundle\Form\DefaultFormCreator</parameter>
         <parameter key="knp_rad.form.type_guesser.data.class">Knp\RadBundle\Form\DataTypeGuesser</parameter>
-        <parameter key="knp_rad.form.type_extension.data.class">Knp\RadBundle\Form\FormTypeExtension</parameter>
 
         <parameter key="knp_rad.reflection.metadata_fetcher.class">Knp\RadBundle\Reflection\ClassMetadataFetcher</parameter>
     </parameters>
@@ -38,11 +37,6 @@
         <service id="knp_rad.form.type_guesser.data" class="%knp_rad.form.type_guesser.data.class%">
             <tag name="form.type_guesser"/>
         </service>
-
-        <service id="knp_rad.form.type_extension.data" class="%knp_rad.form.type_extension.data.class%">
-            <argument type="service" id="knp_rad.form.default_creator"/>
-            <tag name="form.type_extension" alias="form"/>
-        </service>
     </services>
 
 </container>