Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove $entity from flush method #66

Merged
merged 1 commit into from Mar 25, 2013

Conversation

Projects
None yet
3 participants
Contributor

Baachi commented Mar 14, 2013

No description provided.

Member

docteurklein commented Mar 14, 2013

+1

Contributor

gquemener commented Mar 22, 2013

What does it change?

Contributor

Baachi commented Mar 22, 2013

Currently it will throw a PHP notice. See doctrine/doctrine2#166

Contributor

gquemener commented Mar 22, 2013

Interesting... What notice?

Member

docteurklein commented Mar 22, 2013

The flush call with entity parameter will indeed fail, but only if the entity is about to be removed.

For all other cases, it's ok.

@docteurklein docteurklein added a commit that referenced this pull request Mar 25, 2013

@docteurklein docteurklein Merge pull request #66 from Baachi/patch-1
Remove $entity from flush method
96b0de3

@docteurklein docteurklein merged commit 96b0de3 into KnpLabs:develop Mar 25, 2013

1 check failed

default The Travis build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment