Skip to content


Remove $entity from flush method #66

merged 1 commit into from

3 participants


No description provided.

KNP Labs member



What does it change?


Currently it will throw a PHP notice. See doctrine/doctrine2#166


Interesting... What notice?

KNP Labs member

The flush call with entity parameter will indeed fail, but only if the entity is about to be removed.

For all other cases, it's ok.

@docteurklein docteurklein merged commit 96b0de3 into KnpLabs:develop

1 check failed

Details default The Travis build could not complete due to an error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 14, 2013
  1. @Baachi
Showing with 1 addition and 1 deletion.
  1. +1 −1 Controller/Controller.php
2 Controller/Controller.php
@@ -63,7 +63,7 @@ protected function remove($entity, $flush = false)
if ($flush) {
- $this->flush($entity);
+ $this->flush();
Something went wrong with that request. Please try again.