Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove $entity from flush method #66

Merged
merged 1 commit into from

3 participants

@Baachi

No description provided.

@docteurklein

+1

@gquemener
Owner

What does it change?

@Baachi

Currently it will throw a PHP notice. See doctrine/doctrine2#166

@gquemener
Owner

Interesting... What notice?

@docteurklein

The flush call with entity parameter will indeed fail, but only if the entity is about to be removed.

For all other cases, it's ok.

@docteurklein docteurklein merged commit 96b0de3 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 14, 2013
  1. @Baachi
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  Controller/Controller.php
View
2  Controller/Controller.php
@@ -63,7 +63,7 @@ protected function remove($entity, $flush = false)
$this->getEntityManager()->remove($entity);
if ($flush) {
- $this->flush($entity);
+ $this->flush();
}
}
Something went wrong with that request. Please try again.