Make rad entity repository concrete #67

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

gquemener commented Mar 22, 2013

As from KnpLabs/rad-edition@759bcc4
Rad EntityRepository is the default one, it needs to be concrete or the
EntityManager won't be able to instanciate it when the user do not use
a concrete custom repository.

See
https://github.com/doctrine/doctrine2/blob/2.3.2/lib/Doctrine/ORM/EntityManager.php#L689

@gquemener gquemener Make rad entity repository concrete
As from KnpLabs/rad-edition@759bcc4
Rad EntityRepository is the default one, it needs to be concrete or the
EntityManager won't be able to instanciate it when the user do not use
a concrete custom repository.

See
https://github.com/doctrine/doctrine2/blob/2.3.2/lib/Doctrine/ORM/EntityManager.php#L689
4b76c3b
Member

docteurklein commented Mar 22, 2013

ohhh yes.

Member

docteurklein commented Mar 25, 2013

oooh no. After talking with @Herzult , we found out that the method getAlias uses reflection on the repository class itself, which means every querybuilder made with this concrete class will have as root alias entity.

Better to use $repository->getClassName.

Anyway, @Herzult should have sent a fix, so let's close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment