Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bundle usage docs in symfony controllers #105

Open
wants to merge 2 commits into
base: master
from

Conversation

@EliuTimana
Copy link

commented Feb 11, 2018

I found this feature really useful and it's not present in the docs, i hope you can accept this PR, it's my first time contributing to a project. 馃槃

README.md Outdated
@@ -57,6 +57,27 @@ In Twig!
{{ time_diff(someDateTimeVariable) }}
```

In Symfony controllers

This comment has been minimized.

Copy link
@weaverryan

weaverryan Feb 11, 2018

Member

Can you turn this into a header?

README.md Outdated
public function yourAction()
{
...
$dateTimeFormatter = $this->get('time.datetime_formatter');

This comment has been minimized.

Copy link
@weaverryan

weaverryan Feb 11, 2018

Member

We really need to show the autowiring way of getting this service that鈥檚 used in Symfony 4. We should also show the $this->get(), but commented out.

Do you know about the autowiring way? Let me know :)

@weaverryan
Copy link
Member

left a comment

Great idea!

@EliuTimana EliuTimana closed this Feb 15, 2018

@weaverryan

This comment has been minimized.

Copy link
Member

commented Feb 15, 2018

Did you mean to close this! I鈥檒l reopen in case

@weaverryan weaverryan reopened this Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.