Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass extra env vars to compose/swarm build() meth #50

wants to merge 3 commits into
base: master


Copy link

NiR- commented Oct 21, 2019

No description provided.

NiR- added 2 commits Oct 18, 2019
This arg default value was an empty Dict, but it got updated lines later
to set the default stage. As such, when we re-enter using_stack(), the
wrong stage was used.
@NiR- NiR- requested review from neghmurken and nm2107 Oct 21, 2019
nm2107 approved these changes Oct 21, 2019
@@ -286,12 +287,20 @@ def get_ip_address(self, service: str, network: str):
return data[0]['NetworkSettings']['Networks'][network]['IPAddress']

def _run(self, cmd: str, **kwargs) -> subprocess.CompletedProcess:
kwargs.setdefault('env', self._env)
env = self._env.copy()

This comment has been minimized.

Copy link

neghmurken Oct 21, 2019


Can't you encapsulate this merging vars code into a method in BaseStack instead of writing it 4 times?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.