Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default bodyType of Issue/Comments and Repository/Comments #551

Open
wants to merge 1 commit into
base: master
from

Conversation

@bobeagan
Copy link
Contributor

commented Mar 27, 2017

The default value for these configure methods are incorrect per the GitHub API documentation
https://developer.github.com/v3/media/#comment-body-properties

Submitted for consideration with the 3.0 release

update default bodyType of Issue/Comments and Repository/Comments con…
…figure methods

The default value for these are incorrect per the GitHub API documentation
https://developer.github.com/v3/media/#comment-body-properties

@Nyholm Nyholm added this to the Release 3.0 milestone Mar 28, 2017

@Nyholm

Nyholm approved these changes Mar 28, 2017

Copy link
Collaborator

left a comment

Thank you. I agree with this change because it aligns with the documentation and is consistent with the rest of the library.

But as you say, this is a BC break and should be done prior 3.0 release.

If not @cursedcoder argues that this is a bugfix I suggest leaving this PR open until 3.0 is getting closer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.