Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve to can specify parameters on issue comments api. #815

Open
wants to merge 2 commits into
base: master
from

Conversation

@t-kuni
Copy link

commented Oct 6, 2019

I had try to get comments which updated after specific date but it couldn't because can't specify since parameters through this library.

Github API provide since parameter.

https://developer.github.com/v3/issues/comments/#list-comments-on-an-issue
image

but this library can specify page only.
https://github.com/KnpLabs/php-github-api/blob/master/lib/Github/Api/Issue/Comments.php#L39-L56

In this PR, will be able to specify array on 4th argument of Comments#all method.

tig added 2 commits Oct 4, 2019
(cherry picked from commit 9900b21)
tig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.