Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation notice is thrown for twig extension even when twig autoregistration is not enabled #38

Open
akovalyov opened this issue Aug 29, 2016 · 1 comment

Comments

@akovalyov
Copy link
Contributor

commented Aug 29, 2016

Given symfony 3.0
and the following config:

knp_rad_auto_registration:
    enable:
        form_type_extension: ~

The possibility to register the same extension twice ("$extension") is deprecated since version 1.23 and will be removed in Twig 2.0. Use proper PHP inheritance instead.
for each extension available in the codebase. The most irritating thing is that twig extensions autoregistration is not enabled. How can we fix it?

@akovalyov

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2016

Reason: https://github.com/KnpLabs/rad-auto-registration/blame/master/src/Knp/Rad/AutoRegistration/Bundle/AutoRegistrationBundle.php#L46. That's why twig exts are being registered twice. But why was it added? @AntoineLelaisant @PedroTroller maybe you have an idea?

akovalyov added a commit that referenced this issue Sep 10, 2016

@Einenlum Einenlum added the bug label Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.