Travis CI configuration file improvements #5

Merged
merged 2 commits into from Feb 22, 2013

2 participants

@Inoryy

We've improved our Travis CI config file based on one in this repo and encountered some issues here and there in the process.

@docteurklein docteurklein and 2 others commented on an outdated diff Feb 4, 2013
@@ -29,5 +36,6 @@ notifications:
# hipchat: token@room
script:
+ - phpunit -c app src/
@docteurklein
KNP Labs member
docteurklein added a line comment Feb 4, 2013

phpunit ? what's that ?

@docteurklein
KNP Labs member
docteurklein added a line comment Feb 4, 2013

in fact, we don't have a phpunit.xml(.dist) anymore in app folder.

@Inoryy
Inoryy added a line comment Feb 4, 2013

Why do you want to advocate one testing framework over another?
You're free to remove it, of course.

@everzet
everzet added a line comment Feb 4, 2013

Oh, come on. How many times we need to repeat this same thing: this distribution is not for entire world (Symfony standard is). This one is for people that are same-minded as we are. For people who want to be RAD. BDD through PHPUnit is not RAD. We're not advocating anything here, we've made distribution that we will use ourselves. And if you're 90% same-minded with us but prefer to use PHPUnit - just change those 2 lines in composer.json & .travis.yml.

@docteurklein
KNP Labs member
docteurklein added a line comment Feb 4, 2013

no, it's just that with current config, phpunit command will fail. With current composer config, we do know that phpspec is here.

@everzet
everzet added a line comment Feb 4, 2013

And BTW, in some cases (functional testing) even we will need PHPUnit. But we will add it to our client project configuration/composer.json when and if we'll need it, not sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@gquemener gquemener merged commit 4df4105 into master Feb 22, 2013
@gquemener gquemener deleted the travis_fixes branch Feb 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment