Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced Password PseudoRandomBytesGenerator.php #21

Open
wants to merge 1 commit into
base: master
from

Conversation

@AntoineLelaisant
Copy link
Contributor

commented Apr 7, 2017

No description provided.

@AntoineLelaisant AntoineLelaisant force-pushed the feature/update-generators branch 2 times, most recently from 731e1c6 to e32f29b Apr 7, 2017

@AntoineLelaisant AntoineLelaisant force-pushed the feature/update-generators branch from e32f29b to be421ec Apr 7, 2017

@NiR-

This comment has been minimized.

Copy link
Member

commented Apr 7, 2017

I still don't understand why we try to handle salt generation ourselves. password_hash handles it internally. And it's now deprecated (PHP > 7.0) to pass user-generated salt to this function. Also there's a recommended way to store salted passwords based on the form described here.

@AntoineLelaisant

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2017

I totally agree with you, but the goal here was to make a last 2.x version that still works with Symfony2. And then switch to a version 3.x that's supports Symfony3 | PHP 7 and does not handle salts anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.