Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #27 Cannot use { or } in salt. [incomplete] #28

Open
wants to merge 1 commit into
base: master
from

Conversation

@stephanedelprat
Copy link
Contributor

commented Jun 14, 2018

hex2bin make the string twice as long (255 -> 510)

We could use ($this->length / 2) but it can never generate an odd number of chars (like, say, 255)
Or strlen() to trim it.
Or a combination of these two, to have exactly the number of chars specified in the configuration.

Fixes #27 Cannot use { or } in salt. [incomplete]
`hex2bin` make the string twice as long (255 -> 510)

We could use `($this->length / 2)` but it can never generate an odd number of chars (like, say, 255)
Or `strlen()` to trim it.
Or a combination of these two, to have exactly the number of chars specified in the configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.