Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle `eval` removal properly, remove "remove-evals" script and WebpackShellPlugin #398

Merged
merged 2 commits into from Apr 5, 2019

Conversation

Projects
None yet
1 participant
@Kocal
Copy link
Owner

Kocal commented Apr 5, 2019

Q A
Bug fix? yes
New feature? yes/no
Tests pass? yes
Fixed tickets #396

By defining global to 'window', we get rid of the remove-evals script which sometimes works and sometimes does not.
Also removed WebpackShellPlugin that is not useful anymore.

Kocal added some commits Apr 5, 2019

fix(webpack): define `global` as `window` to prevent eval() issues
This way, we get rid of "remove-evals" script that was sometimes working and sometimes not.

@Kocal Kocal merged commit ab1ce52 into master Apr 5, 2019

3 checks passed

WIP Legacy commit status override — see details
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kocal Kocal deleted the fix/no-more-eval branch Apr 5, 2019

Kocal added a commit to Kocal-Web-Extensions/Solary that referenced this pull request Apr 8, 2019

Kocal added a commit to Kocal-Web-Extensions/Solary that referenced this pull request Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.