From 9741efdc5e05d12d564f25c215450690959852ea Mon Sep 17 00:00:00 2001
From: Ilan Steemers <koed00@gmail.com>
Date: Sun, 24 Jan 2016 21:30:42 +0100
Subject: [PATCH] Adds test for task result update

---
 django_q/tests/test_cluster.py | 54 +++++++++++++++++++++++++++++++---
 1 file changed, 50 insertions(+), 4 deletions(-)

diff --git a/django_q/tests/test_cluster.py b/django_q/tests/test_cluster.py
index c5d56eb0..fd8fe0db 100644
--- a/django_q/tests/test_cluster.py
+++ b/django_q/tests/test_cluster.py
@@ -1,16 +1,17 @@
 import sys
-from multiprocessing import Queue, Event, Value
 import threading
+from multiprocessing import Queue, Event, Value
 from time import sleep
-import os
+from django.utils import timezone
 
+import os
 import pytest
 
 myPath = os.path.dirname(os.path.abspath(__file__))
 sys.path.insert(0, myPath + '/../')
 
-from django_q.cluster import Cluster, Sentinel, pusher, worker, monitor
-from django_q.humanhash import DEFAULT_WORDLIST
+from django_q.cluster import Cluster, Sentinel, pusher, worker, monitor, save_task
+from django_q.humanhash import DEFAULT_WORDLIST, uuid
 from django_q.tasks import fetch, fetch_group, async, result, result_group, count_group, delete_group, queue_size
 from django_q.models import Task, Success
 from django_q.conf import Conf
@@ -340,6 +341,51 @@ def test_bad_secret(broker, monkeypatch):
     broker.delete_queue()
 
 
+@pytest.mark.django_db
+def test_update_failed(broker):
+    tag = uuid()
+    task = {'id': tag[1],
+            'name': tag[0],
+            'func': 'math.copysign',
+            'args': (1, -1),
+            'kwargs': {},
+            'started': timezone.now(),
+            'stopped': timezone.now(),
+            'success': False,
+            'result': None}
+    # initial save - no success
+    save_task(task, broker)
+    assert Task.objects.filter(id=task['id']).exists()
+    saved_task = Task.objects.get(id=task['id'])
+    assert saved_task.success is False
+    sleep(0.5)
+    # second save - no success
+    old_stopped = task['stopped']
+    task['stopped']=timezone.now()
+    save_task(task, broker)
+    saved_task = Task.objects.get(id=task['id'])
+    assert saved_task.stopped > old_stopped
+    # third save - success
+    task['stopped']=timezone.now()
+    task['result']='result'
+    task['success']=True
+    save_task(task, broker)
+    saved_task = Task.objects.get(id=task['id'])
+    assert saved_task.success is True
+    # fourth save - no success
+    task['result'] = None
+    task['success'] = False
+    task['stopped'] = old_stopped
+    save_task(task, broker)
+    # should not overwrite success
+    saved_task = Task.objects.get(id=task['id'])
+    assert saved_task.success is True
+    assert saved_task.result == 'result'
+
+
+
+
+
 @pytest.mark.django_db
 def assert_result(task):
     assert task is not None