Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest versions of Arrow will break django-q #377

Closed
natebessa opened this issue Aug 9, 2019 · 3 comments

Comments

@natebessa
Copy link

@natebessa natebessa commented Aug 9, 2019

Hey everyone,

It looks to me like the latest versions of Arrow are breaking Django-Q's scheduled tasks.

Arrow version 0.14.3, released 13 days ago, introduces a change that removes "weeks" and other attributes from its replace() function. This method attribute is still being used in the latest version of Django-Q's scheduler() method as seen here.

I recommend that a maximum version of 0.14.2 for Arrow should be added to Django-Q's setup.py install_requires, or Django-Q's scheduler method should be updated and a minimum version of 0.14.3+ of Arrow should be required.

@Koed00

This comment has been minimized.

Copy link
Owner

@Koed00 Koed00 commented Aug 10, 2019

Fixing this right now.

@eblin

This comment has been minimized.

Copy link

@eblin eblin commented Aug 14, 2019

Yup this affected us as well, mine was for a few daily tasks we have.

CleanShot 2019-08-14 at 09 57 32

Thank you @Koed00 for getting to it quickly, for now I have pinned arrow to 0.14.2

@aleehedl

This comment has been minimized.

Copy link

@aleehedl aleehedl commented Sep 13, 2019

This issue was fixed here: 16fa6fa

Could be closed, right?

@natebessa natebessa closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.