-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SIN-4-FP-21 and SIN-4-FP-20 from NodOn #6429
Conversation
src/devices/nodon.ts
Outdated
e.switch(), | ||
e.power(), | ||
e.energy(), | ||
e.enum('mode', ea.ALL, ['Comfort', 'Eco', 'Anti-Freeze', 'Stop', 'Comfort -1', 'Comfort -2']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make these snake case, e.g. anti-freeze
, comfort_-1
Hello @AlexisPolegato @Koenkk This PR was made while I create one for Also, theses models works like
It's not a big change and can avoid that all future similar devices use it own values no ? |
src/devices/nodon.ts
Outdated
const manufacturerOptions = {manufacturerCode: 0x128B}; | ||
|
||
const fzLocal = { | ||
fil_pilote_mode: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this code is duplicated, could you move it to fromZigbee.ts
/toZigbee.ts
?
Thanks! |
type: ['attributeReport', 'readResponse'], | ||
convert: (model, msg, publish, options, meta) => { | ||
const payload: KeyValueAny = {}; | ||
const mode = msg.data['0']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be const mode = msg.data['mode'];
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you're right ! I seen it this morning I didn't had time to update my PR to fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done here #6465
Hello all I found some issues with the oscilloscope @yoan-m @AlexisPolegato Please review |
Update SIN-4-FP-21 from NodOn to integrate Fil Pilote Cluster
Add SIN-4-FP-20 from NodOn