Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SIN-4-FP-21 and SIN-4-FP-20 from NodOn #6429

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Update SIN-4-FP-21 and SIN-4-FP-20 from NodOn #6429

merged 8 commits into from
Nov 9, 2023

Conversation

AlexisPolegato
Copy link
Contributor

Update SIN-4-FP-21 from NodOn to integrate Fil Pilote Cluster
Add SIN-4-FP-20 from NodOn

e.switch(),
e.power(),
e.energy(),
e.enum('mode', ea.ALL, ['Comfort', 'Eco', 'Anti-Freeze', 'Stop', 'Comfort -1', 'Comfort -2']),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these snake case, e.g. anti-freeze, comfort_-1

@krikristoophe
Copy link
Contributor

krikristoophe commented Nov 8, 2023

Hello @AlexisPolegato @Koenkk

This PR was made while I create one for SIN-4-FP-21_EQU here.
As @yoan-m said, it seem that SIN-4-FP-21_EQU work same as SIN-4-FP-21. Maybe we can add SIN-4-FP-21_EQU to model list in this PR ?

Also, theses models works like Legrand 064882 (Device definition), maybe it can be good to unify values like :

  • mode -> cable_outlet_mode
  • e.enum('mode', ea.ALL, ['comfort', 'eco', 'anti-freeze', 'stop', 'comfort_-1', 'comfort_-2']), -> e.enum('cable_outlet_mode', ea.ALL, ['comfort', 'comfort-1', 'comfort-2', 'eco', 'frost_protection', 'off']),

It's not a big change and can avoid that all future similar devices use it own values no ?

const manufacturerOptions = {manufacturerCode: 0x128B};

const fzLocal = {
fil_pilote_mode: {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this code is duplicated, could you move it to fromZigbee.ts/toZigbee.ts?

@Koenkk Koenkk merged commit 1d692cc into Koenkk:master Nov 9, 2023
@Koenkk
Copy link
Owner

Koenkk commented Nov 9, 2023

Thanks!

type: ['attributeReport', 'readResponse'],
convert: (model, msg, publish, options, meta) => {
const payload: KeyValueAny = {};
const mode = msg.data['0'];
Copy link
Contributor

@yoan-m yoan-m Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be const mode = msg.data['mode']; ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you're right ! I seen it this morning I didn't had time to update my PR to fix it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here #6465

@PoloAlexis
Copy link
Contributor

PoloAlexis commented Nov 14, 2023

Hello all

I found some issues with the oscilloscope

@yoan-m @AlexisPolegato Please review
#6473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants