Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list_drivers by a non-zero length buffer #124

Merged
merged 1 commit into from Nov 10, 2019

Conversation

@palfrey
Copy link
Contributor

palfrey commented Nov 10, 2019

This fixes #112. There's some argument about dropping alloc_info entirely in favour of just doing get_info and then retrying with larger buffers as needed if we fail initially, but this at least seems to sort the initial problem. I have no idea why this actually occurs, or why I can't reproduce this outside of Travis, but this does at least work.

@Koka

This comment has been minimized.

Copy link
Owner

Koka commented Nov 10, 2019

Thanks @palfrey that’s great! Very interesting finding!

@Koka
Koka approved these changes Nov 10, 2019
@Koka Koka merged commit f80cd86 into Koka:master Nov 10, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on fix-list-drivers-length at 58.807%
Details
@palfrey palfrey deleted the palfrey:fix-list-drivers-length branch Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.