Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use criterion for benchmarking #21

Merged
merged 4 commits into from Jul 17, 2019
Merged

Use criterion for benchmarking #21

merged 4 commits into from Jul 17, 2019

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Jul 13, 2019

What have I changed?

  1. Use criterion for benchmarking
  2. Add rustc-hex and faster-hex for benchmarking
  3. Add format and clippy check

koushiro added 2 commits Jul 13, 2019
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro koushiro changed the title Use criterion for benchmarks Use criterion for benchmarking Jul 13, 2019
benches/hex.rs Outdated Show resolved Hide resolved
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro
Copy link
Contributor Author

koushiro commented Jul 16, 2019

@KokaKiwi PTAL :)

benches/hex.rs Show resolved Hide resolved
benches/hex.rs Outdated Show resolved Hide resolved
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro
Copy link
Contributor Author

koushiro commented Jul 17, 2019

BTW, I recommend squash and merge, which will make the commit history clearer :)

@KokaKiwi KokaKiwi merged commit 264b89f into KokaKiwi:master Jul 17, 2019
1 check passed
@koushiro koushiro deleted the bench branch Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants