Skip to content

Conversation

@Kolaru
Copy link
Owner

@Kolaru Kolaru commented Aug 22, 2021

Fix #21 and #23.

Support for \mathrm, \mathit and \mathbf.

Also export get_font([family], fontstyle) -> font_object::FTFont and get_fontpath([family], fontstyle) -> path for easy access to the fonts from the outside world.

@knuesel I'm interested by your opinion on the latter, before merging.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2021

Codecov Report

Merging #27 (1b452b6) into master (88b62d1) will increase coverage by 0.55%.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   75.86%   76.42%   +0.55%     
==========================================
  Files           8        9       +1     
  Lines         489      509      +20     
==========================================
+ Hits          371      389      +18     
- Misses        118      120       +2     
Impacted Files Coverage Δ
src/MathTeXEngine.jl 100.00% <ø> (ø)
src/prototype.jl 0.00% <ø> (ø)
src/engine/fonts.jl 78.94% <69.23%> (-7.42%) ⬇️
src/engine/layout.jl 92.12% <90.62%> (+0.25%) ⬆️
src/engine/layout_context.jl 93.75% <93.75%> (ø)
src/engine/texelements.jl 86.88% <100.00%> (ø)
src/parser/commands_registration.jl 85.91% <100.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b62d1...1b452b6. Read the comment docs.

@AshtonSBradley
Copy link

My opinion FWIW is that convenience functions are great, but shouldn't hold up an important merge that affects all user plots. I know I'm impatient (sorry!) but could this be split so we don't have to wait?

@knuesel
Copy link
Contributor

knuesel commented Aug 24, 2021 via email

@Kolaru
Copy link
Owner Author

Kolaru commented Aug 24, 2021

@knuesel Thanks for the quick feedback. We are still pre 1.0 so this can be changed without fuss latter as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add font command support

5 participants