Skip to content

Commit

Permalink
Added komodoproject files to ignore list
Browse files Browse the repository at this point in the history
  • Loading branch information
@th3coop
th3coop committed Mar 6, 2015
1 parent fa837d0 commit 480f84e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .gitignore
View file
Expand Up @@ -28,5 +28,6 @@ src/codeintel/!src/patches/
src/codeintel/test2/scan_actual/
src/codeintel/test2/tmp*
src/codeintel/tmp/
*.komodoproject
install/
packages/

5 comments on commit 480f84e

@Naatan
Copy link
Member

@Naatan Naatan commented on 480f84e Mar 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already exists? See line 19.

@th3coop
Copy link
Member Author

@th3coop th3coop commented on 480f84e Mar 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see that. I keep my project file in a sub folder (src) so the rule at line 19 won't work. It only applies to komodoproject files in repo root dir. I'd think in most cases people wouldn't want to include a komodo project file in their projects git repo. If they did they could remove the rule. I think we should swap line 19 for the rule I added.

@Naatan
Copy link
Member

@Naatan Naatan commented on 480f84e Mar 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep mine in the root of the repo and change the source dir to ./src. Just change the rule you added to be /src/*.komodoproject (be explicit).

@sgtcoder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually tried doing this in my git, but it doesn't work: *.komodoproject

It only takes it if I put the full komodoproject path in there.

Example: Domain API - sub.domain.com.komodoproject

@Defman21
Copy link
Contributor

@Defman21 Defman21 commented on 480f84e Mar 31, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codermjb it works for me: https://github.com/Defman21/madnessBot/blob/master/.gitignore#L3
Maybe the dots in your project name causes .gitignore to fail the *.komodoproject match but I'm unsure about that.

Please sign in to comment.