New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LESS syntax checking broken #1061

Closed
Naatan opened this Issue Feb 5, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@Naatan
Member

Naatan commented Feb 5, 2016

Install latest LESS: npm install -g less and point Komodo at it.

Write some obviously invalid CSS (don't even worry about LESS specifics), eg

foo { bar; 

The syntax check passes, no errors detected.

@Naatan Naatan added this to the 10.0 milestone Feb 5, 2016

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Feb 5, 2016

I doubt this is a regression. It looks like LESS decided to change its output format again.

@Naatan

This comment has been minimized.

Member

Naatan commented Feb 5, 2016

Confirmed, if I downgrade all the way down to LESS 1.2 it works. Seems they changed the output shortly after that, and checking the output for different versions it doesn't seem to have changed much since.

@Naatan

This comment has been minimized.

Member

Naatan commented Feb 5, 2016

Old format (version 1.2):

ParseError: Syntax Error on line 21 in /home/nathan/Projects/komodo-dev/src/chrome/komodo/skin/global/components/customize.less:21:20
20 
21     background-color: @contrast;
22     background-image: url("koicon://ko-svg/chrome/icomoon/skin/move.svg?color=@{escaped-special}");

New format (version 2.6):

ParseError: Unrecognised input in /home/nathan/Projects/komodo-dev/src/chrome/komodo/skin/global/components/customize.less on line 21, column 21:
20 
21     background-color: @contrast;
22     background-image: url("koicon://ko-svg/chrome/icomoon/skin/move.svg?color=@{escaped-special}");
@Defman21

This comment has been minimized.

Contributor

Defman21 commented Feb 6, 2016

^ God of git rebase.
Anyway I fixed that, now I can see errors with your example Nathan :)

@babobski

This comment has been minimized.

Contributor

babobski commented May 25, 2016

The "Use build-in Less Syntax Checker" is not working in komdo 10.
When I use this example, I get no linting errors

foo { bar; 

2016-05-25 08_48_18

@babobski

This comment has been minimized.

Contributor

babobski commented May 25, 2016

As work around, if you have node.js configured in komodo, you can point to the lessc file from the less repo as interpreter.
You will now get linting errors:
2016-05-25 10_38_01

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented May 25, 2016

There is no built-in Less syntax checker. That option should not exist. You must have lessc installed somewhere and configure Komodo to point to it.

@Naatan

This comment has been minimized.

Member

Naatan commented May 25, 2016

Huh, we do indeed show a "Use built-In Less Syntax Checker" option. Bug logged here: #1607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment