New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Bookmark bad behavior #1110

Closed
cdcmicro opened this Issue Feb 25, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@cdcmicro

cdcmicro commented Feb 25, 2016

Short Summary

Commenting a block that contains bookmarked lines clears bookmarks and adds a bookmark on the last line of the block. Commenting here refers to pressing Ctrl-/ with a series of lines selected in the editor. Possibly related to #754.

Steps to Reproduce

Start with:

screenshot_022516_014220_pm

Press Ctrl-/ to comment-out the block

Expected results

screenshot_022516_020111_pm

Actual results

screenshot_022516_014538_pm

The "new" bookmark on line 5 requires several Ctrl-F2 presses to clear it.

If the comment/new bookmark is on a block-closing line, sometimes no number of Ctrl-F2 presses will clear it until I F2 to it from elsewhere and Ctrl-F2 again.

The behavior is the same whether I create the bookmarks with Ctrl-F2 or Ctrl-Shift-digit except the "new" bookmark shows the indicator for the highest-numbered bookmark in the commented selection.

Platform Information

Komodo Edit or IDE? IDE
Komodo Version? 9.3.2, build 88191, platform win32-x86
Operating System (and version)? Win7 x64

@cdcmicro

This comment has been minimized.

cdcmicro commented Feb 25, 2016

Doesn't seem to be language-sensitive. Behaves the same in javascript.

@Naatan Naatan changed the title from Bookmark bad behavior to Quick Bookmark bad behavior Feb 26, 2016

@Naatan

This comment has been minimized.

Member

Naatan commented Feb 26, 2016

@mitchell-as I guess this is because the commenting code rewrites the lines entirely rather than modifies them?

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Feb 26, 2016

Yes, that would do it.

@mitchell-as mitchell-as added this to the 9.3.3 milestone Feb 26, 2016

@mitchell-as mitchell-as self-assigned this Feb 26, 2016

mitchell-as added a commit that referenced this issue Feb 29, 2016

fix: editing: Prevent line/block commenting and uncommenting from rem…
…oving line markers - fixes #1110

rn=

(integrated from master branch change 9.2.1-848-g18baf47 by Mitchell <mitchellb@activestate.com>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment