New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Komodo regains focus after save #1331

Closed
lagbox opened this Issue Apr 29, 2016 · 33 comments

Comments

Projects
None yet
6 participants
@lagbox
Contributor

lagbox commented Apr 29, 2016

Short Summary

It seems if you save, then change to another window quickly Komodo will regain focus.

Steps to Reproduce

This is happening for me in my profile and in safe mode.

Use Commando's File Scope to open a file.
Save any file you have open.
Change focus to any other application, or change desktops.
Komodo regains focus within 0.5-1 second.

Update:
If I activate Commando File Scope via key bindings, even without selecting or opening a file from it, this issue occurs from that point.

Expected results

For Komodo to not regain focus after focus has been given to something else.

Actual results

Komodo will regain focus.

Platform Information

Komodo Edit or IDE? IDE
Komodo Version? 10 Alpha build 88986
Operating System (and version)? Ubuntu 15.10

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Apr 29, 2016

Sadly, I'm not fast enough of a ninja to trigger this.

The thing that comes to mind is an "after-save" action that takes a while to complete. When it does, Komodo refocuses on something. That may be caused by an add-on or userscript.

Can you reproduce this in safe mode? (Help > Troubleshooting > Restart in Safe Mode)

@lagbox

This comment has been minimized.

Contributor

lagbox commented Apr 29, 2016

Doesn't appear that I can reproduce in safe mode.

@lagbox

This comment has been minimized.

Contributor

lagbox commented Apr 29, 2016

Now that I am back in regular mode, it seems it isn't happening any more, so far.

@Naatan

This comment has been minimized.

Member

Naatan commented Apr 29, 2016

I'll close this for now then, let us know if it happens again.

@Naatan Naatan closed this Apr 29, 2016

@lagbox

This comment has been minimized.

Contributor

lagbox commented Apr 29, 2016

Started happening again, while in regular operation. I will look to see what addons or scripts are running.
I can't figure out any steps to reproduce, besides time.

@lagbox

This comment has been minimized.

Contributor

lagbox commented Apr 29, 2016

Updated with a method that I can reproduce consistently after opening a project.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Apr 29, 2016

Reproduced. You have about 500-1000ms after saving a file to do alt-tab.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Apr 29, 2016

And just saying - you don't have to modify it, so I don't know why Komodo still doing save operation if there were no changes made.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Apr 29, 2016

I can't reproduce this on Windows. I'm hitting Alt+Tab in less than 1 second for sure.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Apr 29, 2016

you don't have to modify it

@Defman21 are you saying you have the issue with a clean profile?

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Apr 29, 2016

Yeah.

@Naatan

This comment has been minimized.

Member

Naatan commented Apr 30, 2016

And just saying - you don't have to modify it, so I don't know why Komodo still doing save operation if there were no changes made.

A save is a save. If you don't modify it it's equivalent to touching the file. I don't like apps that try to be smarter than they need to be.

On topic - I still cannot reproduce this. Maybe it's a Ubuntu thing? @mitchell-as do the new steps above work for you?

@lagbox

This comment has been minimized.

Contributor

lagbox commented Apr 30, 2016

I have limited this to the use of selecting a file to open via Commando's File Scope, even without using bindings to open it or using enter to select it. Just using it to open the file, from that point on this happens. I will update the steps again, to remove the unneeded steps to reproduce.
I can reproduce this in safemode, just by using the File Scope to open any file.

@robclancy

This comment has been minimized.

robclancy commented Apr 30, 2016

This happens for me on Arch Linux with i3.

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented May 2, 2016

@Naatan I still cannot reproduce this, even with the updated steps. I am using a clean profile.

  1. I open a project.
  2. I use commando to open a file in that project.
  3. I type space and backspace, save, and immediately Alt+Tab.
  4. Komodo stays in the background.
  5. I go back to Komodo, open another file via commando, go back to the first file, save, and Alt+Tab.
  6. Again, nothing; Komodo stays in the background.

This is on Ubuntu 14.04.

@Naatan

This comment has been minimized.

Member

Naatan commented May 2, 2016

@robclancy @lagbox have you guys had this issue on a clean profile (in safe mode)?

@lagbox

This comment has been minimized.

Contributor

lagbox commented May 2, 2016

yes I can reproduce in safe mode.

@Naatan

This comment has been minimized.

Member

Naatan commented May 2, 2016

Does the timing of the file open and the method to open the file play into this?

@robclancy

This comment has been minimized.

robclancy commented May 2, 2016

I have been using komodo for a while today and avoiding commando and it never happened. Right after using commando to open a file it happens and for me you don't even need to be very fast to make it happen. And the file doesn't need to change at all. Also it doesn't just regain focus once it tries to refocus during the time of it happening. So if I am fast enough to change again after it regains focus the first time it will steal it back again.

Since I have some performance issues sometimes and this issue lasts longer for me I would guess that those with no performance issues also on a fast computer simply can't do it fast enough to trigger the issue which is why you are having trouble reproducing it.

EDIT: I have yet to make a new profile and don't want to incase this profile being slower (assuming a new profile fixes my performance issues) might help find the problem. Should I create a new one?

@lagbox

This comment has been minimized.

Contributor

lagbox commented May 2, 2016

I have isolated it to Commando File Scope to open any file. From that point on, this issue happens.
I also can reproduce by opening the File Scope via key bindings, then escaping out of it.

@Naatan

This comment has been minimized.

Member

Naatan commented May 2, 2016

Also it doesn't just regain focus once it tries to refocus during the time of it happening. So if I am fast enough to change again after it regains focus the first time it will steal it back again.

That gave me what I needed. Thanks!

@Naatan Naatan closed this in 2861e09 May 2, 2016

@Naatan Naatan added Type: Bug and removed Pending: Internal labels May 2, 2016

@Naatan Naatan added this to the 10.0 milestone May 2, 2016

@Naatan Naatan self-assigned this May 2, 2016

@lagbox

This comment has been minimized.

Contributor

lagbox commented May 6, 2016

This is still present in 10.0.0-beta1, build 89095

@Naatan

This comment has been minimized.

Member

Naatan commented May 6, 2016

I don't think it's commando related then. Wish I could repro :\

@lagbox

This comment has been minimized.

Contributor

lagbox commented May 6, 2016

I can reproduce in safe-mode and in my profile. Ill play with it more to see if I can come up with alternate steps.

@robclancy

This comment has been minimized.

robclancy commented May 6, 2016

It's fixed for me so far, tried steps I did before to make it work and it doesn't happen.

@lagbox

This comment has been minimized.

Contributor

lagbox commented May 6, 2016

Its still there for me with my profile if I just load Command File Scope, the problem exists after that point.
In safe-mode, I am opening a project, opening a file from the places, then using the file scope to open any file. After that this happens for me.

@robclancy

This comment has been minimized.

robclancy commented May 6, 2016

I was just able to reproduce. My settings had changed so the same steps were actually slightly different. I guess I hadn't noticed it before because not used the Command File Scope.

@Naatan

This comment has been minimized.

Member

Naatan commented May 6, 2016

Are you getting this on Komodo 9 also?

@robclancy

This comment has been minimized.

robclancy commented May 6, 2016

Yes. It only triggers if I use a bind to go to Command File Scope. I couldn't reproduce until I add the bind. Using everything scope and going to files then open never caused it to happen.

@Naatan Naatan reopened this May 6, 2016

@lagbox

This comment has been minimized.

Contributor

lagbox commented May 6, 2016

I can reproduce on 9.3 when using the File Scope via bindings to open a file. After that point it will steal focus back after a save.
Safe Mode: Opening Commando via bindings [Ctrl+Shift+o] -> file scope -> pick a file and open. After this point the save will grab focus.

@Naatan Naatan modified the milestones: 10.0, 10.0.1 May 18, 2016

@Naatan Naatan added the New label Jun 10, 2016

@Naatan Naatan modified the milestones: 10.0.1, 10.1 Jun 10, 2016

@Naatan Naatan modified the milestones: 10.1, 10.1.2 Aug 30, 2016

@lagbox

This comment has been minimized.

Contributor

lagbox commented Sep 26, 2016

Present on latest.

Komodo IDE, version 10.1.1, build 89474, platform linux-x86_64.
Built on Thu Sep 1 14:52:01 2016.

@Naatan Naatan closed this in 8c06d4a Nov 15, 2016

@lagbox

This comment has been minimized.

Contributor

lagbox commented Nov 15, 2016

Thanks for looking and putting in the time guys. I appreciate it. :)

@Naatan

This comment has been minimized.

Member

Naatan commented Nov 16, 2016

Thanks for helping me look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment