New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect phpunit.phar better #1422

Closed
Defman21 opened this Issue May 7, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@Defman21
Contributor

Defman21 commented May 7, 2016

Short Summary

Atm Komodo is looking for phpunit.phar in include_path of php.ini. This could be a bit tweaked so Komodo will look for $PATH as well. I've created a patch for this issue.

--- a/HarnessSelector.php   2016-05-06 22:10:27.132774994 +0300
+++ b/HarnessSelector.php   2016-05-07 14:59:14.683248602 +0300
@@ -1,5 +1,5 @@
 <?php
-    
+set_include_path(get_include_path() . PATH_SEPARATOR . getenv("PATH"));
     /**
      * @author  Michael Heim
      * @link    http://www.zeilenwechsel.de/

I've tested it as well. It works fine.

include_path

unit test

@Naatan Naatan added this to the 10.1 milestone May 7, 2016

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jun 17, 2016

@Defman21 which HarnessSelector.php is your patch for? Base/HarnessSelector or Ko/HarnessSelector?

Thanks!

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Jun 18, 2016

I don't remember :\

I assume it's Base/HarnessSelector. Gonna try.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Jun 18, 2016

Yes, it's Base/HarnessSelector. Still works good! :)
Imgur

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jun 20, 2016

Thanks @Defman21! Closed via Komodo/KomodoIDE@777653c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment