New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tcl code analyzer fails #1570

Closed
sgeard opened this Issue May 20, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@sgeard

sgeard commented May 20, 2016

Short Summary

Outlining and code analysis are incorrect for some procedures

Steps to Reproduce

Open the attached file, you'll see that moveToPosition has collapsed the remainder of the file and the code analyzer has the second procedure 'f' in the wrong place.

bug

bug.tcl.gz

Expected results

moveToPosition should only collapse to its end and 'f' should be at an equal level within the namespace.

Actual results

see attached png

Platform Information

*Komodo IDE
*Komodo Version 10.0.0
Linux-x64

Additional Information

@mitchell-as mitchell-as added this to the 10.1 milestone May 23, 2016

@mitchell-as mitchell-as self-assigned this May 23, 2016

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented May 23, 2016

Thanks for the report. It looks like you found an edge case in our Tcl lexer.

@sgeard

This comment has been minimized.

sgeard commented May 23, 2016

If you unfold the proc moveToPosition you'll see that the # characters in the regexps cause the highlighting to go wrong. Is that part of the same problem?

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented May 23, 2016

Yes, the two are likely linked.

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jun 29, 2016

Note to self: the '#' is also responsible for putting f within the current function. Removing # puts f on its own.

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jun 30, 2016

By not treating the # characters in the regexps as comment delimiters, both the folding issue and the incorrectly nested f have been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment