Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
About Komodo dialog is hiding version information with contributor list #1632
If I add
Edit, disregard section option:
@Naatan can you weigh in on the first suggestion? Is that viable? This could resolve the same issue for other dialogs as it's that bottom margin causing the issue that you can see in my last screenshot and it's Windows only.
Bah sorry, I thought you were saying to add sizeToContent() to the about dialog xul, not the window binding.
I'm hesitant about putting it on the window binding as it might have side effects, eg. on windows that have content too large to fit on screen. Also it likely affects the window restore (doesn't restore the size it was closed at anymore).
I'm not against this change but it needs further investigation, likely better to put it in 10.1 than 10.0.1. @cgchoffman up to you, either we revert this and add it only to the about dialog xul, or we leave it in but you'll need to do some exhaustive testing on Windows to ensure it doesn't have any side effects.
Sorry, my bad for not reading your comment properly.