New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Komodo dialog is hiding version information with contributor list #1632

Closed
cgchoffman opened this Issue May 30, 2016 · 10 comments

Comments

Projects
None yet
3 participants
@cgchoffman
Member

cgchoffman commented May 30, 2016

Short Summary

See the screenshot.

Uploading Capture.PNG…

@cgchoffman cgchoffman added this to the 10.0.1 milestone May 30, 2016

@cgchoffman cgchoffman self-assigned this May 30, 2016

@Defman21

This comment has been minimized.

Contributor

Defman21 commented May 30, 2016

Nice screenshot.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented May 30, 2016

haha indeed.
capture

@Naatan

This comment has been minimized.

Member

Naatan commented May 30, 2016

I blame @jeff-hobbs :p

@Naatan Naatan added the Type: UX label May 30, 2016

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Jun 8, 2016

If I add window.sizeToContent() on line 200 in windows.p.xml this resolves the issue.
https://github.com/Komodo/KomodoIDE/blob/master/src/chrome/komodo/content/bindings/windows.p.xml#L199

Edit, disregard section option:
We could add it to window.resize instead but i'm unclear what the repercussions of that would be.

@Naatan can you weigh in on the first suggestion? Is that viable? This could resolve the same issue for other dialogs as it's that bottom margin causing the issue that you can see in my last screenshot and it's Windows only.

@Naatan

This comment has been minimized.

Member

Naatan commented Jun 8, 2016

Yes, that sounds like a good solution.

@cgchoffman cgchoffman closed this in fd8cc7d Jun 8, 2016

@Naatan

This comment has been minimized.

Member

Naatan commented Jun 8, 2016

Bah sorry, I thought you were saying to add sizeToContent() to the about dialog xul, not the window binding.

I'm hesitant about putting it on the window binding as it might have side effects, eg. on windows that have content too large to fit on screen. Also it likely affects the window restore (doesn't restore the size it was closed at anymore).

I'm not against this change but it needs further investigation, likely better to put it in 10.1 than 10.0.1. @cgchoffman up to you, either we revert this and add it only to the about dialog xul, or we leave it in but you'll need to do some exhaustive testing on Windows to ensure it doesn't have any side effects.

Sorry, my bad for not reading your comment properly.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Jun 8, 2016

I suspected the same thing which is why I asked. I'm fine with reverting it. I can add it to the onload on the about.xul and see if that fixes it. I can't find any of the dialogs that had the same issue any more :(

cgchoffman added a commit that referenced this issue Jun 8, 2016

Revert "force fit window to content win32. fixes #1632"
This reverts commit fd8cc7d. Could have
too far reaching effects.
@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Jun 8, 2016

I don't see a dialog.xml binding. Even adding it there could be too broad though,if it existed. Maybe this is just a "case by case" scenario?

@Naatan

This comment has been minimized.

Member

Naatan commented Jun 8, 2016

I meant chrome://komodo/content/about/about.xul.

I think this is likely indeed a case by case type of thing.

@Naatan Naatan reopened this Jun 8, 2016

@cgchoffman cgchoffman closed this in 1ae0d9f Jun 8, 2016

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Jun 8, 2016

Thanks for the help @Naatan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment