New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commando file scope fails when project has "added" remote folders #1657

Closed
cgchoffman opened this Issue Jun 2, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@cgchoffman
Member

cgchoffman commented Jun 2, 2016

Steps to Reproduce

Create a project
Right click > Add > Existing remote folder
Open Commando > File scope (must go directly to file scope, ie. press 4 in the first scope)
Search for a file in that folder (or any file in your project even if it's not in the "added" folder)

Expected results

To Find it.

Actual results

No files are shown at all.

@cgchoffman cgchoffman added the Type: Bug label Jun 2, 2016

@cgchoffman cgchoffman added this to the 10.0.1 milestone Jun 2, 2016

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Jun 2, 2016

@Naatan Naatan added Type: Enhancement and removed Type: Bug labels Jun 3, 2016

@Naatan Naatan modified the milestones: 10.1, 10.0.1, 11 Jun 3, 2016

@Naatan

This comment has been minimized.

Member

Naatan commented Jun 3, 2016

This is not a bug, it has never worked as it was beyond the scope of the Commando. As were remote files. Maybe we can flesh this out for Komodo 11.

@Naatan Naatan changed the title from Commando file scope fails when project has "added" folders to Add support for "Existing Folders" and Remote Files to Commando Jun 3, 2016

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Jun 3, 2016

But it fails completely. It doesn't find ANY files if there is an added file, even files in the project root. That is a bug.

@Naatan

This comment has been minimized.

Member

Naatan commented Jun 3, 2016

-- Figuring this out with Carey in chat, seems I may have missunderstood some parts of the bug --

@cgchoffman cgchoffman changed the title from Add support for "Existing Folders" and Remote Files to Commando to Commando file scope fails when project has "added" remote folders Jun 3, 2016

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Jun 3, 2016

The only thing i missed is that it was a remote folder that broke commando. This is a bug as commando file scope no longer works at all for any files or folders whether they are remote or local.

@cgchoffman cgchoffman added Type: Bug and removed Type: Feature labels Jun 3, 2016

@Naatan

This comment has been minimized.

Member

Naatan commented Jun 3, 2016

Ok, so it seems I was wrong on two counts here:

  • one, this bug is about commando not working at all when existing folders are used (I'm unable to reproduce this so far)
  • two, I in fact DID implement support for existing folders, but downright forgot about it .. -.-

My apologies. Moving on to reproducing this bug. I'm unable to reproduce this on Linux, Carey is trying if it's OS specific.

@Naatan

This comment has been minimized.

Member

Naatan commented Jun 3, 2016

Issue reproduced, it stems from "Existing Remote Folders". Relevant error:

[2016-06-03 12:42:20,352] [ERROR] console-logger: Error: 'scp://Test/home/nathan/Downloads' does not have a local path (2) in chrome://komodo/content/library/uriparse.js:168
Traceback (most recent call last):
  File "chrome://komodo/content/library/uriparse.js", line 168, in 

This breaks the files scope completely.

@Naatan Naatan modified the milestones: 10.0.1, 11 Jun 3, 2016

@Naatan Naatan closed this in c765cbd Jun 3, 2016

@stramin

This comment has been minimized.

stramin commented Jun 3, 2016

Thank you so much for all your work guys!

You are the best!

@cgchoffman cgchoffman added moved to qa and removed moved to qa labels Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment