New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default keyboard shortcuts should respect platform standards #1665

Closed
hayne opened this Issue Jun 6, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@hayne

hayne commented Jun 6, 2016

Short Summary

The defaults for some keyboard shortcuts in Komodo Edit do not conform to what OS X users expect

Steps to Reproduce

The keyboard shortcut for Find Next is F3 by default.
OS X users (and my fingers) expect that it is Command-G

The keyboard shortcut for Replace (in Edit menu) is Command-H by default.
But Command-H on OS X is the usual shortcut for hiding the whole application.
(And is listed as such in the application menu ("Komodo Edit") at top left.)
I don't have a suggestion as to what to do for the keyboard shortcut for Replace

  • but it definitely should not be that which is used system-wide for hiding an application.

Expected results

The default for Find Next should be Command-G on OS X
The keyboard shortcut Command-H should always hide the application.

Platform Information

Komodo Edit 10.0.0
OS X 10.9.5

@cgchoffman cgchoffman added this to the 10.0.1 milestone Jun 6, 2016

@cgchoffman cgchoffman self-assigned this Jun 6, 2016

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Jun 6, 2016

Thanks @hayne. Good points. I'll have a look at these and find better alternatives.

@hayne

This comment has been minimized.

hayne commented Jun 6, 2016

textwrangler_searchmenu

msword_findmenu

Above I have attached screenshots (on OS X) of the Search menu from TextWrangler (free version of BBEdit) and the Find menu of Microsoft Word (Office 2011 for Mac) - these show some possibilities for the various keyboard shortcuts

cgchoffman added a commit that referenced this issue Jun 8, 2016

mac friendly, hand friendly binding change #1665
rn=

(integrated from master branch change 0cc4356 by Carey Hoffman <cgchoffman@gmail.com>)
@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Jun 8, 2016

81819fc
Komodo/KomodoIDE@0cc4356

Explanation for changes made (note internally cmd = meta in Komodo):
I've followed the suggestions made by @hayne for find next, Meta+G
For replace I've used the legacy command as I can't think of a better one.

I had to change the debugging commands since they were using meta+G. *Start debugging* and *start debugging but skip dialog* areMeta+.andMeta+shift+>` respectively.

I also took the liberty to change (probably shouldn't have...waiting for posterior to be bitten) the step in, step out and step over bindings so that are in an intuitive position and all located under the right hand rather than various locations around the keyboard.
I had an arrow pad in mind, i being up (step out), k being down (step in), and l being right (step over). They are all preceded by Meta+Ctrl+.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Jun 9, 2016

If you want to give this a spin you'll be able to use it in the latest nightly which will be available in just over an hour.

@cgchoffman cgchoffman added moved to qa and removed moved to qa labels Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment