New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getMostRecentWindow calls with ko/windows.getMain() #1695

Closed
Naatan opened this Issue Jun 10, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@Naatan
Member

Naatan commented Jun 10, 2016

getMostRecentWindow will cause bugs if it is called asynchronously, as it could return the wrong window (ie. window this is being called from could be in background while other window is in foreground).

@Naatan Naatan added this to the 10.1 milestone Jun 10, 2016

@Naatan Naatan self-assigned this Jun 10, 2016

@Naatan Naatan closed this in 97f3e4e Jul 27, 2016

@cgchoffman cgchoffman added moved to qa and removed moved to qa labels Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment