New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Places selection affects commit dialog #1757

Closed
Naatan opened this Issue Jun 28, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@Naatan
Member

Naatan commented Jun 28, 2016

Short Summary

Title

Steps to Reproduce

Create a new git repo and point Komodo at it. Create a structure of :

FolderA/fileA
FolerB/fileB

Commit all files. Then modify fileA. Now select FolderB in places and launch the commit dialog via the dynamic toolbar button.

Expected results

A commit dialog that shows fileA being modified

Actual results

A commit dialog with no modifications.

The commit dialog appears to be scoping in on the selected Places directory -- this should not happen. The commit dialog should always be scoped on the project or Places root directory, unless the user explicitly defines otherwise (eg. by right clicking a folder).

@Naatan Naatan added this to the 10.1 milestone Jun 28, 2016

@Naatan Naatan self-assigned this Jun 28, 2016

@Naatan

This comment has been minimized.

Member

Naatan commented Jun 29, 2016

Fixed with Komodo/KomodoIDE@ee07f18

To work around this issue you can just set your focus on the editor and then use the VCS button.

@Naatan Naatan closed this Jun 29, 2016

@cgchoffman cgchoffman added moved to qa and removed moved to qa labels Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment