New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker does not work in SASS #1815

Closed
Defman21 opened this Issue Jul 19, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@Defman21
Contributor

Defman21 commented Jul 19, 2016

Short Summary

title. It does not recognize any sort of color (hex, rgb, color name, etc.)

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jul 19, 2016

Thanks for the report.

@mitchell-as mitchell-as added this to the 10.1 milestone Jul 19, 2016

@Naatan Naatan assigned mitchell-as and unassigned Naatan Aug 2, 2016

@Naatan

This comment has been minimized.

Member

Naatan commented Aug 2, 2016

Works in SCSS, not in SASS.

@mitchell-as I suspect this is some sort of language toggle?

@Naatan

This comment has been minimized.

Member

Naatan commented Aug 3, 2016

I almost feel we should just enable this by default for all languages. If it annoys people they can just disable the color picker hyperlinking but I can't think of many cases where a color value could be missinterpreted. Thoughts?

Edit: Not to mention they would have to be holding control and hovering over a value to even get this. The false positives that this would produce would be very minimal and even when they would occur I cannot see them being overly frustrating or anything, whereas not having the color hyperlinking for languages we have not anticipated could definitely be frustrating.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 3, 2016

I have no issue with that @Naatan.

@Naatan

This comment has been minimized.

Member

Naatan commented Aug 3, 2016

Mitchell agreed too (long as we exclude color constants).

Committed here - 0c15f43

@Naatan

This comment has been minimized.

Member

Naatan commented Aug 3, 2016

Anyone reading this that doesn't like the change, you can revert the behavior with:

require("ko/prefs").setBoolean('hyperlinksColorpickerAlwaysEnable', false)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment