New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS Linter does not recognize WARNING messages #1820

Closed
Defman21 opened this Issue Jul 19, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@Defman21
Contributor

Defman21 commented Jul 19, 2016

Short Summary

With this code:

body

There will be a warning:

WARNING on line 1 of /home/defman/sample.sass:
This selector doesn't have any properties and will not be rendered.

Komodo does not recognize it in any form.

@mitchell-as mitchell-as added this to the Perpetual milestone Jul 19, 2016

@mitchell-as mitchell-as self-assigned this Jul 19, 2016

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Jul 19, 2016

@mitchell-as would you mind accept a PR for this one? :)

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jul 19, 2016

Thanks for the report. The linter will need to add a warning pattern matcher, but since Sass is second-class to SCSS, it's not high on the priority list.

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jul 19, 2016

@Defman21 go for it!

Defman21 added a commit to Defman21/KomodoEdit that referenced this issue Jul 19, 2016

Linter: CSS: fixed Komodo#1820 (SASS Linter does not recognize WARNIN…
…G messages)

Signed-off-by: Defman21 <i@defman.me>

mitchell-as added a commit that referenced this issue Sep 26, 2016

Merge pull request #1825 from Defman21/issue-1820
Linter: CSS: fixed #1820 (SASS Linter does not recognize WARNING mess…

Naatan added a commit that referenced this issue Nov 8, 2016

Merge pull request #1825 from Defman21/issue-1820
Linter: CSS: fixed #1820 (SASS Linter does not recognize WARNING mess…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment