New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tcl Highlight - no highlight on substitute variable in curly braces #1831

Closed
mickey263 opened this Issue Jul 20, 2016 · 12 comments

Comments

Projects
None yet
4 participants
@mickey263

mickey263 commented Jul 20, 2016

Short Summary

TCL variable substitution in curly braces isn't highlighted

Steps to Reproduce

set foo 1
puts $foo
puts ${foo}

Expected results

${foo} is highlighted

Actual results

${foo} isn't highlighted

Platform Information

Komodo IDE 10.0.1 build 89237
win32-x86

Additional Information

-- eg. Error logs, screenshots, workarounds --
capture

@mickey263

This comment has been minimized.

mickey263 commented Jul 20, 2016

Hello,

For my own information, why highlight the $ ?

Thanks

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jul 20, 2016

Hi, I'm not able to reproduce this. See image below.

tcl

I see you are using a custom color scheme. If you switch to one of the default color schemes, do you get the correct highlighting?

@mickey263

This comment has been minimized.

mickey263 commented Jul 20, 2016

In your example, foo is not highlighted.

Here with default color scheme :

capture1

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Jul 20, 2016

Mitchell, he means variable highlighting

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jul 20, 2016

Okay, then there is no bug here with unhighlighted variables in braces (${foo}) -- it was your color scheme that wasn't showing them. As for highlighting the foo in set foo 1, this is not trivial to do from Komodo's perspective and is another issue anyway.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Jul 20, 2016

@mitchell-as you still don't get me. When you click on a variable, Komodo underlines references to this variable in the code. $ErrorIndex is underlined, but ${ErrorIndex} is not.

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jul 20, 2016

Mind your tone @Defman21. I'm not addressing you. I'm addressing the original ticket.

@mickey263

This comment has been minimized.

mickey263 commented Jul 20, 2016

Sorry i have a begginer level in English, so i have difficulties to explain my issue.

@Defman21 understood my problem. It's well in the case when i click on a variable, komodo don't highlight all corresponding variable "tag" in my code

@mickey263

This comment has been minimized.

mickey263 commented Jul 20, 2016

I understand what you talk about @mitchell-as.
Syntax color is ok, but not the komodo function :

Variable Highlighting
Click on a variable to see all occurrences.
@Defman21

This comment has been minimized.

Contributor

Defman21 commented Jul 20, 2016

@mitchell-as sorry for that. I didn't want to sound in bad tone at all :)

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Jul 20, 2016

Thank you both for your clarification. I understand the problem now. With my previous experience, the word "highlight" to me always means "syntax highlight" :) I have trouble realizing it can also mean "variable highlight". This is a bug that I will look into fixing.

@mitchell-as mitchell-as reopened this Jul 20, 2016

@mitchell-as mitchell-as added this to the 10.1 milestone Jul 20, 2016

@mitchell-as mitchell-as self-assigned this Jul 20, 2016

@mickey263

This comment has been minimized.

mickey263 commented Jul 20, 2016

Thanks ! For me too, highlight mean syntax color ^^
Komodo introduces a double mean...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment