New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink works once again after closing the color picker #1876

Closed
Defman21 opened this Issue Jul 31, 2016 · 16 comments

Comments

Projects
None yet
4 participants
@Defman21
Contributor

Defman21 commented Jul 31, 2016

Short Summary

I'm able to reproduce it 100%.

Steps to Reproduce

Hold Ctrl and click on a color. Press Esc. Hover on another color.

Expected results

I won't highlight in any form.

Actual results

It highlights like with Ctrl being pressed.

Platform Information

Komodo Edit or IDE? IDE
Komodo Version? 10.0.1
Operating System (and version)? elementary OS 0.4

Additional Information

It does work not only for colors. Everything that Komodo could recognize as a hyperlink will be highlighted with the corresponding indicator.

Pressing Esc workarounds the problem.

@mitchell-as mitchell-as added this to the 10.1 milestone Aug 1, 2016

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Aug 1, 2016

Thanks for the report. It sounds like the color picker panel is not forwarding the 'escape' keypress on to Scintilla to cancel the "control mode" or whatever was enabled at the time of Ctrl+Clicking.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Aug 1, 2016

Actually, I'm able to reproduce it by just closing the color picker with Ok or Cancel button. Not every time, but very often.

@Naatan

This comment has been minimized.

Member

Naatan commented Aug 2, 2016

I'm unable to reproduce this, nor is there any logic that I can see which tracks whether a link is currently active.

@Defman21 can you try safe-mode?

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Aug 2, 2016

Yes, I can.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Aug 2, 2016

Wait.. I'm using a Komodo Edit build so it's kinda clear. I've made no changes to it except for adding alpha control in color picker, which is not related to hyperlinking. I'm able to reproduce the issue. I'm using Gala WM.

@Naatan

This comment has been minimized.

Member

Naatan commented Aug 2, 2016

Can you reproduce it on IDE?

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Aug 2, 2016

I can. Otherwise I would not have accepted the ticket. I should have explicitly stated that I reproduced the issue in my original response though.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Aug 2, 2016

@Naatan yep, it's a bit random, but after 1-2 opens of colorpicker I'm able to reproduce it.

@Naatan

This comment has been minimized.

Member

Naatan commented Aug 2, 2016

Weird, I can trigger it as many times as I want without issues. Have you found any workarounds?

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Aug 2, 2016

Pressing Esc after closing the dialog.

@Naatan

This comment has been minimized.

Member

Naatan commented Aug 2, 2016

As in pressing it twice? Your reproduction steps specifically state pressing ESC as one of the steps to reproduce.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Aug 2, 2016

  • You open the color picker
  • You close it somehow (Ok, Cancel of Esc)
  • You press Esc <- workaround
@Naatan

This comment has been minimized.

Member

Naatan commented Aug 2, 2016

Ok. When it isnt working does the editor have focus? (ie. do you see the caret blinking).

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Aug 2, 2016

When I'm able to reproduce it, I can click on hyperlinks (after closing the picker it will run the related actions). When I'm not - then it does not have any focus.

@Naatan

This comment has been minimized.

Member

Naatan commented Aug 2, 2016

Ok so the links work but they won't highlight?

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Aug 2, 2016

I'll record a video.

@Naatan Naatan closed this in dcf250b Aug 2, 2016

@cgchoffman cgchoffman added moved to qa and removed moved to qa labels Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment