New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Open Recent Files Hard to Read in Classic Mode #1930

Closed
mitchell-as opened this Issue Aug 16, 2016 · 11 comments

Comments

Projects
None yet
5 participants
@mitchell-as
Member

mitchell-as commented Aug 16, 2016

Short Summary

From http://forum.komodoide.com/t/recent-file-drop-down-list-uses-non-contrasting-colors-very-hard-to-read/3028:

The recent files menu on the new tab screen is hard to read in classic mode.

Steps to Reproduce

  1. Open two files.
  2. Close them.
  3. Ctrl+T for new tab.
  4. Click on the arrow on the "Open File" button.

Expected results

Easy to read menu options.

Actual results

Hard to read menu options.

Platform Information

Komodo Edit or IDE? Both
Komodo Version? 10.1 beta
Operating System (and version)? Any

Additional Information

-- eg. Error logs, screenshots, workarounds --

recent

@jimtut

This comment has been minimized.

jimtut commented Aug 16, 2016

This behavior appears in other drop-downs too. It's probably all the same element/style, but I thought I'd add it here too. When editing the properties of a custom toolbox item, the menu that lets you select from all the built-in "variables" behaves the same:

image

@jimtut

This comment has been minimized.

jimtut commented Aug 16, 2016

There is a similar style problem, although this one MIGHT be different. In the Debugging Options window, highlighting text in the input boxes uses a dark blue background and dark text:

image

@Naatan Naatan closed this in 7d0f397 Aug 16, 2016

@Naatan Naatan modified the milestones: 10.1, 10.2 Aug 16, 2016

@jimtut

This comment has been minimized.

jimtut commented Aug 16, 2016

That was fast, Naatan! Is there any LESS/CSS file I can modify here now to get this change with the current version?

Also, what did you think about the 2nd pic I added, showing the color problem in the Debugging Options dialog?

@Naatan

This comment has been minimized.

Member

Naatan commented Aug 16, 2016

@jimtut you might be able to use this CSS:

:not(button) > button:not(.button-toolbar-a):not(.unstyled):not(.spinbuttons-button),
.button
{
    &:hover label.button-text
    {
        color: @selected-foreground !important;
    }
}

But I'm not certain it'll work with just that, as there is some cascading going on.

As for the debugging options issue you raised (text selections), please open a new bug for this. I had not seen that, but it illustrates perfectly why we cannot track multiple bugs in one bug report ;)

@jimtut

This comment has been minimized.

jimtut commented Aug 16, 2016

I know, you're right about the multiple bugs in one ticket! I was kind of hoping that it's related, but it's probably a different element/style Bug #1932 created.

@rjasdf

This comment has been minimized.

rjasdf commented Aug 20, 2016

The FIND string field is just as bad as the image provided by jimtut.

Suggest you go through all color schemes and check for contrasting foreground/background.

@jimtut

This comment has been minimized.

jimtut commented Sep 6, 2016

This is marked as Closed, and the Milestone is set to 10.1, but this bug is still present in 10.1.

@Naatan

This comment has been minimized.

Member

Naatan commented Sep 6, 2016

Make sure you're using the Classic scheme and not a copy of it.

Also make sure you're running 10.1.

@jimtut

This comment has been minimized.

jimtut commented Sep 6, 2016

Sorry, you're right! Thanks again.

@rjasdf

This comment has been minimized.

rjasdf commented Sep 7, 2016

With 10.1, the Find menu shows black text on dark blue. This is using "Classic" (not a copy of it.)
It is black on white until "pattern not found", then it becomes the unreadable combo.

@Naatan

This comment has been minimized.

Member

Naatan commented Sep 7, 2016

Please report a new bug.

@cgchoffman cgchoffman added moved to qa and removed moved to qa labels Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment