New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar icon color colors both top icons and side icons #1962

Closed
babobski opened this Issue Aug 24, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@babobski
Contributor

babobski commented Aug 24, 2016

Short Summary

When you use the color editor, you can set the toolbar icon color, only this affects the icons in the top bar and the icons in the left sidebar. These items should be controlled separate.
2016-08-24 07_44_43
Now I can't see the icons in the sidebar anymore.
2016-08-24 07_45_26

Expected results

That you can control these items separate from each other.

Platform Information

Komodo Ide 10.1

Additional Information

As workaround you probably can fix this with a bit of custom css

@Naatan

This comment has been minimized.

Member

Naatan commented Aug 24, 2016

This is fixed in the release build, sounds like you're still on the beta.

@Naatan Naatan closed this Aug 24, 2016

@babobski

This comment has been minimized.

Contributor

babobski commented Aug 24, 2016

@Naatan if i'm correct I'm not using the beta.

[2016-08-24 20:06:38,395] [INFO] Startup: Welcome to Komodo IDE 10.1.0 build 89455 (platform win32-x86, running on Windows post2012Server version 6.3.9600)
@Naatan

This comment has been minimized.

Member

Naatan commented Aug 24, 2016

Can you share a color scheme that reproduces the issue?

@Naatan Naatan reopened this Aug 24, 2016

@babobski

This comment has been minimized.

Contributor

babobski commented Aug 25, 2016

You can find the color scheme of the screenshots here

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Aug 28, 2016

Able to reproduce it with the Redmond color scheme. Komodo IDE, version 10.1.0, build 89455, platform win32-x86.
Built on Mon Aug 22 08:23:01 2016.

@babobski

This comment has been minimized.

Contributor

babobski commented Aug 28, 2016

Changing the color to the editor foreground fixes the issue.

#komodo_main #toolbox_side toolbaritem > toolbarbutton:before,
#komodo_main #toolbox_side toolbaritem > toolbarbutton toolbarbutton:before,
#komodo_main #toolbox_side toolbaritem > toolbarbutton dropmarker:before {
    color: @foreground !important;
}

@Naatan Naatan added Bug: New and removed Pending: Response labels Aug 30, 2016

@Naatan Naatan added this to the 10.2 milestone Aug 30, 2016

@Naatan Naatan self-assigned this Aug 30, 2016

@Naatan Naatan modified the milestones: 10.1.1, 10.2 Aug 30, 2016

@Naatan Naatan closed this in cd46a52 Aug 30, 2016

Naatan added a commit that referenced this issue Aug 30, 2016

Colors: Fix side toolbar icon color not respecting color pref - fixes #…
…1962

(integrated from the KomodoIDE master branch change 1c80b9a by Nathan Rijksen <n.rijksen@gmail.com>)

Komodo/KomodoIDE@1c80b9a

@cgchoffman cgchoffman added moved to qa and removed moved to qa labels Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment