New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find All does not work in Komodo Edit latest update #1964

Closed
Eduardo-M-Cavalcanti opened this Issue Aug 24, 2016 · 47 comments

Comments

Projects
None yet
9 participants
@Eduardo-M-Cavalcanti

Eduardo-M-Cavalcanti commented Aug 24, 2016

Short Summary

"Find All" in Komodo Edit 10.1 (recent latest update) does not work. Shows error message.

Steps to Reproduce

Load text file and make a "Find All"

Expected results

searched string ocurrences

Actual results

Error message and no results.

Platform Information

Komodo Edit or IDE?
Komodo Edit

Komodo Version?
recent latest: 10.1

Operating System (and version)?
Windows 10

Additional Information

-- eg. Error logs, screenshots, workarounds --
komodo search error

@Eduardo-M-Cavalcanti Eduardo-M-Cavalcanti changed the title from Find All does not work in Komodo Edit lastest update to Find All does not work in Komodo Edit latest update Aug 24, 2016

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 24, 2016

please include your logs Help > Troubleshooting > View Log File. Make sure you've reproduced the issue. I'm not able to reproduce this on the latest Edit.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 24, 2016

Also, if that error in your screenshot isn't in the logs, please copy and paste it here from the notifications pane View > Tabs & Sidebars > Notifications.

@Eduardo-M-Cavalcanti

This comment has been minimized.

Eduardo-M-Cavalcanti commented Aug 24, 2016

Here goes the log file.
pystderr.log.txt

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 24, 2016

thank you but I don't see anything about Find in that log file. Did you reproduce the issue before sending the log file? Also please send the notification error as well.

@Eduardo-M-Cavalcanti

This comment has been minimized.

Eduardo-M-Cavalcanti commented Aug 24, 2016

The error will not show in notifications. I have reproduced the error twice before sending the log file. Now I wil try to reinstall Komodo.

@Eduardo-M-Cavalcanti

This comment has been minimized.

Eduardo-M-Cavalcanti commented Aug 24, 2016

Thanks for you fast response.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 24, 2016

Do you have errors turned off in the notifications tab? That's definitely a notification and should be showing up there.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 24, 2016

Not the icons in the bottom right of the tab x, ! and i to enable/disable errors, warnings and info notifications respectively.

@mazhar10

This comment has been minimized.

mazhar10 commented Aug 24, 2016

I see the same problem in Komodo Edit. Doing a Find All results in the status bar indicating "Preparing... finding XXX in YYY" and never progresses. This happens in both Komodo Edit and Komodo IDE.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 24, 2016

@mazhar10 please see the information I'm requesting and provide it if you can. Please try restarting and re-installing as well. I can't reproduce this in IDE or Edit.

@Eduardo-M-Cavalcanti

This comment has been minimized.

Eduardo-M-Cavalcanti commented Aug 24, 2016

Reinstalling Komodo in this latest version did not fix the error.
The Notification area remained empty even after pressing the content type toggle buttons. By the way they do not give feedback for change of state.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 24, 2016

@Eduardo-M-Cavalcanti thanks for checking and good point on the toggle buttons. That's annoying. We'll have to make due with the image of the notification I guess. @mazhar10 can you please confirm that you get the same error message?

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 24, 2016

BTW: #1965, thanks for pointing that out.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 24, 2016

Oh, @Eduardo-M-Cavalcanti could you do me a favour? Run the following snippet in the Console Tab in the bottom pane, reproduce the issue, then copy your log file here again.

Snippet

ko.logging.getLogger("find.functions").setLevel(ko.logging.LOG_DEBUG);

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 24, 2016

Also, how are either of you triggering Find? Exact steps please.

@mazhar10

This comment has been minimized.

mazhar10 commented Aug 24, 2016

I launch it using SHIFT-CTL-F.
I cannot reproduce it in Komodo Edit on a Windows 10 and a windows 2008 R2 Enterprise machine. I have only Komodo Edit on these 2 machines.

I have Komodo Edit and Komodo IDE on a Windows 2008 R2 Standard machine where I can always reproduce the issue in both Edit and IDE. I uninstalled and reinstalled Komodo IDe on this machine and the issue persists.

@mazhar10

This comment has been minimized.

mazhar10 commented Aug 24, 2016

On the machine where I can reproduce the issue, it makes no difference whether I invoke the find featuer via SHIFT-CTL-F or via the menu - it does not work in either case.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 24, 2016

Hi @mazhar10 , logs please. see my comment above:#1964 (comment) You can do that too.

@WheelDogs

This comment has been minimized.

WheelDogs commented Aug 25, 2016

Count me in. This occurred with newly loaded 10.0.1. However, in some instances the attached occurs, as well. Notice the "preparing" message in the lower window.

image 1

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 25, 2016

Thank you @WheelDogs but a screenshot isnt very helpful. Please see my comments above. I need logs: #1964 (comment)

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 25, 2016

Also, @WheelDogs what do you mean by "This occurred with newly loaded 10.0.1." What is newly loaded?

@WheelDogs

This comment has been minimized.

WheelDogs commented Aug 25, 2016

Hi,

oops. 10.1.0

No issue with 10.0.1
figured others have already done so. Also, can fall back to preceding version.
Bigger for me is #1960. "info" There is no fallback.

Just posted image as requested.

@Eduardo-M-Cavalcanti

This comment has been minimized.

Eduardo-M-Cavalcanti commented Aug 25, 2016

Hi @cgchoffman,
Log attached.
komodo log.txt

@WheelDogs

This comment has been minimized.

WheelDogs commented Aug 25, 2016

Meant Komodo 10.1.0 – that is the version that produced the ‘find’ problem.

From: Carey Hoffman [mailto:notifications@github.com]
Sent: Wednesday, August 24, 2016 8:19 PM
To: Komodo/KomodoEdit
Cc: WheelDogs; Mention
Subject: Re: [Komodo/KomodoEdit] Find All does not work in Komodo Edit latest update (#1964)

Also, @WheelDogs https://github.com/WheelDogs what do you mean by "This occurred with newly loaded 10.0.1." What is newly loaded?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #1964 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AUJ9BnDkxXab53xrVMsD5lhi9kqedkoxks5qjN9qgaJpZM4JseM7 .Image removed by sender.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 25, 2016

@Eduardo-M-Cavalcanti, something odd in those logs for sure. But the find logs don't tell much. @mazhar10 I'm still interested in what you're logs look like.

@Eduardo-M-Cavalcanti can you try Help > Troubleshooting > Restart without Addons?

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 25, 2016

I'm getting the feeling this is related to updating. Did all of you just use the Auto-update feature to get to the latest 10.1 Komodo?

@mazhar10

This comment has been minimized.

mazhar10 commented Aug 25, 2016

I did an update through the "check for updates" feature. However, upon
encountering the bug, I uninstalled and reinstalling with no joy.

--Moby

On 8/25/2016 15:19, Carey Hoffman wrote:

I'm getting the feeling this is related to updating. Did all of you
just use the Auto-update feature to get to the latest 10.1 Komodo?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1964 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUPvb7GK05PyKjWh2p-AglWxOio6TVKFks5qjfjjgaJpZM4JseM7.


Mobeen Azhar
mailto:moby@pcsn.net mailto:nadeem@pcsn.net
PC.Solutions.Net
http://www.pcsn.net http://www.pcsn.net/
Voice: 281-880-0738 x 104, Fax: 281-587-0844
Cisco Select Certified, HP Partner, IBM Business Partner, Microsoft Gold
Certified Partner


Get your free account at http://www.premiersurvey.com

@BillStud

This comment has been minimized.

BillStud commented Aug 25, 2016

I can confirm that this is happening on Windows 7 (64bit) also.
Komodo IDE, version 10.1.0, build 89455, platform win32-x86. Built on Mon Aug 22 08:23:01 2016.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 25, 2016

@mazhar10 3rd times the charm I guess; Logs please.

@BillStud, if you could share your log file as well I would appreciate it.

Please make sure you follow the command I mentioned earlier to enable debug logging: #1964 (comment)

@mitchell-as mitchell-as self-assigned this Aug 25, 2016

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Aug 25, 2016

I confirm this happens in both IDE and Edit and does not log anything to the error log. I have a feeling I caused this :(

All I had to do was create a new document, enter "foo" a few times, Edit > Find, enter "foo", and then click "Find All". I get a nasty red error message that I cannot read.

@BillStud

This comment has been minimized.

BillStud commented Aug 25, 2016

I don't have Python installed on my current machine; I cannot seem to run a command from the console.
logging seems to be disabled too. Help->Troubleshooting->View Log File does not produce anything

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 25, 2016

I don't have Python installed on my current machine;

@BillStud, it's JavaScript. View > Tabs & Sidebars > Console. But it looks like @mitchell-as might know what's going on.

@mitchell-as, nice to have repro-steps now! Can I assign this to you since you seem to have an idea of whats' going on?

@BillStud

This comment has been minimized.

BillStud commented Aug 25, 2016

@cgchoffman: I updated by clicking on the notification pop-up for the update. That's when the issue started happening for me.

@BillStud

This comment has been minimized.

BillStud commented Aug 25, 2016

The Rx toolkit is finding the matches correctly.

@BillStud

This comment has been minimized.

BillStud commented Aug 25, 2016

Finally tracked down my error log file

pystderr.log.txt

@mazhar10

This comment has been minimized.

mazhar10 commented Aug 25, 2016

Here is my log file - sorry for the delay on getting it.
pystderr.log.txt

@WheelDogs

This comment has been minimized.

WheelDogs commented Aug 25, 2016

Yes

From: Carey Hoffman [mailto:notifications@github.com]
Sent: Thursday, August 25, 2016 4:20 PM
To: Komodo/KomodoEdit
Cc: WheelDogs; Mention
Subject: Re: [Komodo/KomodoEdit] Find All does not work in Komodo Edit latest update (#1964)

I'm getting the feeling this is related to updating. Did all of you just use the Auto-update feature to get to the latest 10.1 Komodo?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #1964 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AUJ9BpJ1ILcJqOUj6Gl6zaaUW1N1u4gMks5qjfjjgaJpZM4JseM7 .Image removed by sender.

@Eduardo-M-Cavalcanti

This comment has been minimized.

Eduardo-M-Cavalcanti commented Aug 25, 2016

@cgchoffman,
Here goes the log for Help > Troubleshooting > Restart without Addons. Same situation.
komodo log.txt
Regards.

@Eduardo-M-Cavalcanti

This comment has been minimized.

Eduardo-M-Cavalcanti commented Aug 25, 2016

@WheelDogs,
I think it is not related to upgrading. I have uninstalled and reinstalled Komodo and the error persists. But I did not purge the Komodo configuration data between reinstalls.

@mbeddow

This comment has been minimized.

mbeddow commented Aug 26, 2016

Same here. Problem is 100% reproducible on all files, in all ways if invoking Find All in current file and after uninstall of auto-updated 10.1 and reinstall from scratch. Starting in safe mode makes no difference.

Details of platform are in attached log (I have redacted the sftp:// path in one item for reasons of project confidentiality)

In my case, the command succeeds to the extent that all the instances of the find target are indeed highlighted in the main display. But the hits list remains empty.

Though I have notifications turned on, nothing appears in the notification pane. I get a tiny red notification window as shown in the OPs screenshot, but it's on screen for only 1 second, and I can't either read it properly or trigger a screen cap in time to grab it.

Clutching at straws here... but are those with the same problem which the developers apparently can't reproduce maybe running, as I am, in a locale other than US-English? Not that locales should matter nowadays for modern software, but my locale is Korean.

komodo10.1.log.txt

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Aug 26, 2016

It wasn't me, but I found the problem nonetheless: 385d674#diff-de37d61d844ca651e0a7f40fe417ec05R126

This will need to be cherry-picked onto the 10.1.x branch whenever it's created.

@mitchell-as mitchell-as reopened this Aug 26, 2016

cgchoffman added a commit that referenced this issue Aug 26, 2016

fix: find: Fix "Find All" from failing - fixes #1964
rn=

(integrated from the KomodoIDE master branch change b004e9e by Mitchell <mitchellb@activestate.com>)

Komodo/KomodoIDE@b004e9e
@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 26, 2016

There are nightlies ready now. FYI Windows Edit and OSX Edit failed for some reason and I couldn't get them included. I'm very sorry about that. I'll be looking into this later to see if I can fix the issue with the build system.

IDE: http://downloads.activestate.com/Komodo/nightly/komodoide/latest-10.1.x/
Edit: http://downloads.activestate.com/Komodo/nightly/komodoedit/latest-10.1.x/

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 26, 2016

For those of you who need the OSX and Windows edit builds I am going to try to resolve whatever is wrong with those builds tonight and push a new nightly tomorrow so you aren't left out. It would be available around 12 noon, PDT August 27.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Aug 27, 2016

OSX build finished last night. Staged all bits just now. Confirmed they will be live around 12 noon.

@cgchoffman cgchoffman closed this Aug 27, 2016

Naatan added a commit that referenced this issue Aug 30, 2016

fix: find: Fix "Find All" from failing - fixes #1964
rn=

(integrated from the KomodoIDE master branch change b004e9e by Mitchell <mitchellb@activestate.com>)

Komodo/KomodoIDE@b004e9e
@Eduardo-M-Cavalcanti

This comment has been minimized.

Eduardo-M-Cavalcanti commented Aug 30, 2016

The situation is fixed in build Komodo-Edit-10.1.0-17406 (nightly build).
Thanks.

@codewiseio

This comment has been minimized.

codewiseio commented Feb 8, 2017

I am receiving this same error:

Komodo Edit, version 10.1.4, build 17456, platform win32-x86. Built on Fri Dec 16 19:15:05 2016

@Naatan

This comment has been minimized.

Member

Naatan commented Feb 8, 2017

Please open a new bug report and provide all details requested.

@cgchoffman cgchoffman added moved to qa and removed moved to qa labels Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment