New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic tabstops not working anymore in 10.1.0 #1989

Closed
ANSI-C opened this Issue Sep 1, 2016 · 12 comments

Comments

Projects
None yet
4 participants
@ANSI-C

ANSI-C commented Sep 1, 2016

Short Summary

They don't work anymore in last release

Steps to Reproduce

Paste this code in a perl file:

my $a   = 1;
my $longvariablename    = 2;

Expected results

equal signs should align

Actual results

the don't (used to do)

Platform Information

Komodo Edit or IDE? IDE
Komodo Version? version 10.1.0, build 89455, platform win32-x86
Operating System (and version)? Windows 8.1

Additional Information

-- eg. Error logs, screenshots, workarounds --

@ANSI-C

This comment has been minimized.

ANSI-C commented Sep 1, 2016

Probably web form turned tabs to spaces, but you get the idea.

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Sep 1, 2016

You must have both "Prefer Tabs over Spaces" and "Enable Elastic Tab Stops" checked in Edit > Preferences > Editor > Indentation before pasting in text with tabs in it. Once I did that, it works.

@mitchell-as mitchell-as closed this Sep 1, 2016

@ANSI-C

This comment has been minimized.

ANSI-C commented Sep 1, 2016

I already had it that way, double checked before opening the ticket, it does not work:

sshot-2016-09-01- 17-49-03

@ANSI-C

This comment has been minimized.

ANSI-C commented Sep 1, 2016

Can you acknowledge the bug, or is there any other setting to change to make it working?

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Sep 1, 2016

Did you use the auto-updater to update to Komodo 10.1 from 10.0.1? If so, do you mind re-installing 10.1 directly? It's possible the elastic tabstops module got lost in the update. I don't understand why it would do that though...

@ANSI-C

This comment has been minimized.

ANSI-C commented Sep 1, 2016

Hi, language setting is preferring tabs over spaces as well, this is puzzling for me too, it used to work before latest update. I made no changes to the configuration.

sshot-2016-09-01- 18-30-03

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Sep 1, 2016

I believe you. I don't believe the elastic-tabstops module is being loaded. The only way it wouldn't be loaded is if it didn't exist, and the only way it wouldn't exist (I think) is if it got lost in the update. I see two fixes:

  • Try a full 10.1 reinstall (no auto-update from 10.0.1) if you can.
  • Go to your existing install's lib/mozilla/ folder and copy everything from distribution/bundles/elastic-tabstops@activestate.com/ into extensions/elastic-tabstops@activestate.com/. Then restart Komodo.
@ANSI-C

This comment has been minimized.

ANSI-C commented Sep 1, 2016

Hi, yes, I did the update in place. Now uninstalled the previous version and trying to install from scratch the next button remains disabled:
sshot-2016-09-01- 22-29-02

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Sep 1, 2016

The directory needs to be empty. Please clear it before proceeding. There may be a residual file or folder or two.

@ANSI-C

This comment has been minimized.

ANSI-C commented Sep 1, 2016

Directory was non existent, changed the path anyway and then has been able to reinstall from scratch.
Elastic tabstops still not working.

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Sep 1, 2016

Okay, it appears that our build system is no longer packaging elastic tabstops correctly. I talked to one of our devs and the packaging for elastic tabstops did change from 10.0 to 10.1 so it looks like there's a bug somewhere. In this case, you must manually copy the elastic-tabstops@activestate.com/ folder from your installation's lib/mozilla/distribution/bundles/ to lib/mozilla/extensions/ folder. Then restart Komodo. Sorry for all the trouble :(

@mitchell-as mitchell-as added this to the 10.1.2 milestone Sep 1, 2016

@mitchell-as mitchell-as modified the milestones: 10.2, 10.1.2 Sep 1, 2016

@Naatan Naatan modified the milestones: 10.1.1, 10.2 Sep 1, 2016

@Naatan Naatan closed this in 020d29a Sep 1, 2016

Naatan added a commit that referenced this issue Sep 1, 2016

Elastic tabstops: Fix elastic tabstops no longer being packaged with …
…Komodo - fixes #1989

rn=

(integrated from the KomodoIDE master branch change 3027310 by Nathan Rijksen <n.rijksen@gmail.com>)

Komodo/KomodoIDE@3027310
@ANSI-C

This comment has been minimized.

ANSI-C commented Sep 1, 2016

Hello, the workaround fixed the problem, many thanks.
Let us know if there are other extensions that need to be moved.

@cgchoffman cgchoffman added moved to qa and removed moved to qa labels Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment