New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cant move default color picker #2036

Closed
babobski opened this Issue Sep 22, 2016 · 12 comments

Comments

Projects
None yet
4 participants
@babobski
Contributor

babobski commented Sep 22, 2016

Short Summary

If you have a color at the bottom of you're window, and you trigger the colorpicker.
You're unable to move the color picker, so you can't access the buttons.

Platform Information

Komodo Ide 10.1.1 Windows 10

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Sep 22, 2016

ColorPicker is a <window> object so you should able to move it. It works on Linux.

@babobski

This comment has been minimized.

Contributor

babobski commented Sep 22, 2016

2016-09-22 14_31_08-
Had the same problem problem with the rgba colorpicker with the implementation of the xul wrapper.
It uses a dialog, witch I cant move on windows, to fix it I had to change it into a window.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Sep 22, 2016

Try to use native decorations? If they are working, so you probably won't be able to move any dialog in Komodo without native decorations.

UPD: sorry, the built-in color picker uses <dialog>.

@babobski

This comment has been minimized.

Contributor

babobski commented Sep 22, 2016

When using native decorations I can move the color picker.
When I'm not using native decorations, there are windows I can move ( like the preferences window, project preferences ) and there are windows that cannot be moved like the properties of a toolbox-item.
And the run command window doesn't use a xul wrapper.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Sep 22, 2016

None of these you named are using <dialog> except for properties of a toolbox item.

Also you're missing the meaning of xul wrapper - it's being used to wrap HTML so it could access XUL itself (chrome:// urls, Less, etc.). You should be able to move Run Command window because it's a window, not a dialog.

@babobski

This comment has been minimized.

Contributor

babobski commented Sep 22, 2016

You should be able to move Run Command window because it's a window, not a dialog.

Added the note for the run command, because it's missing the decorated border, it's already using native decoration.
2016-09-22 15_06

@Naatan

This comment has been minimized.

Member

Naatan commented Sep 22, 2016

There are definitely some dialogs that cannot be moved. These should pretty much exclusively be modal dialogs. I'm not having any issue moving the color picker one when native decorations are disabled. @cgchoffman could you test on Windows? I only have access to OSX today :\

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Sep 22, 2016

Confirmed @babobski bug: I can't move color picker on Windows with native decorations disabled.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Sep 23, 2016

This is Windows only. I can move dialogs without native decorations.

@Naatan Naatan added Bug: New and removed Pending: Internal labels Sep 23, 2016

@Naatan Naatan added this to the 10.2 milestone Sep 23, 2016

@Naatan Naatan self-assigned this Sep 23, 2016

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Oct 1, 2016

#1621 could be related to this.

@babobski

This comment has been minimized.

Contributor

babobski commented Oct 1, 2016

Looks like it's the default behavior for a dialog on windows.
If I look at the dialogs under https://github.com/Komodo/KomodoEdit/tree/master/src/chrome/komodo/content/dialogs all the windows that are using "dialog" I can't move.
alert.xul, compare.xul, iconpicker.xul are all using the "dialog" type and I can't move any of them.

@Defman21

This comment has been minimized.

Contributor

Defman21 commented Oct 1, 2016

It's a bug. It would be an excepted behavior if it would behave in the same way across all systems (OSX, Linux, Windows).

@Naatan Naatan closed this in c63dea5 Jan 16, 2017

Naatan added a commit that referenced this issue Jan 16, 2017

Colorpicker: The color picker is now draggable on Windows - fixes #2036
rn=

(integrated from the KomodoIDE master branch change 88da0ee by Nathan Rijksen <n.rijksen@gmail.com>)

Komodo/KomodoIDE@88da0ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment