New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang_nodejs.py compares upper cased 'fileName' with lower cased name #2087

Closed
lmk1988 opened this Issue Oct 6, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@lmk1988

lmk1988 commented Oct 6, 2016

Short Summary

lang_nodejs.py compares upper cased 'fileName' with lower cased name

Steps to Reproduce

  1. Create Project
  2. Use require('app-module-path').addPath(__dirname)
  3. Specify Node.js directory in language/Node.js
  4. Directory added with upper cased naming (e.g D:\myCode)
  5. Code Intel does not work

Why it does not work (in lang_nodejs.py)

  1. Code Intel enters method load_as_file() with "D:\myCode\index.js"
  2. Code Intel enters get_hits_from_lib()
  3. From (os.path.normpath(blob.get("src")) != filename:) it compares failure with d:\mycode\index.js

How to workaround/fix

  1. Add filename = filename.lower(); at the start of method get_hits_from_lib();

Platform Information

Komodo Edit
10.1
Windows 10

@cgchoffman cgchoffman added the Type: Bug label Oct 6, 2016

@cgchoffman cgchoffman added this to the 10.2 milestone Oct 6, 2016

@mitchell-as

This comment has been minimized.

Member

mitchell-as commented Oct 6, 2016

Thank you very much for the detail of the ticket and suggested fix. It made my job easier :)

Naatan added a commit that referenced this issue Nov 8, 2016

fix: codeintel: NodeJS: Fixed file-case descrepancy on Windows - fixes
…#2087

rn=

(integrated from the KomodoIDE master branch change 0ce1853 by Mitchell <mitchellb@activestate.com>)

Komodo/KomodoIDE@0ce1853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment