New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation leaks to next line when inside object #2180

Closed
Naatan opened this Issue Nov 23, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@Naatan
Member

Naatan commented Nov 23, 2016

Steps to Reproduce

Create a javascript file with the following contents

var foobar = {
    k1: {
        
    },
    k2: {
        
    },
    k3: {
        
    },
};

Select lines 2 through 4 and press TAB 3 times

Expected results

Lines 2 through 4 are indented 3 times.

Actual results

Each time TAB is pressed it expands the selection by one line to the bottom, you'll end up with lines 2 through 7 selected.

@cavac

This comment has been minimized.

cavac commented Nov 25, 2016

Reproduced the Bug on Komodo IDE, version 10.1.2, build 89508, platform linux-x86_64.

@Naatan Naatan modified the milestones: 10.1.3, 10.2 Nov 28, 2016

mitchell-as added a commit that referenced this issue Nov 28, 2016

fix: editor: Fixed regression in selection position when changing ind…
…entation - fixes #2180

Introduced in fix to #900.

rn=

(integrated from the KomodoIDE master branch change 5ce466e by Mitchell <mitchellb@activestate.com>)

Komodo/KomodoIDE@5ce466e
@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 29, 2016

Nightly build with a fix for this will be available around 12 PST today. I will update this ticket when it's available.

@cgchoffman

This comment has been minimized.

Member

cgchoffman commented Nov 29, 2016

FYI, once we release 10.1.3, if you have installed this nightly, Komodo will automatically prompt you to auto-update to the mainline release.

@cavac

This comment has been minimized.

cavac commented Nov 30, 2016

Confirmed: Nightly fixed the problem on Ubuntu 16.04 x64 for IDE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment